Repository navigation
Commit 89d3da9
Register a field's callbacks when the page is registered, not when it renders
A field set's constructor is what registers a field's search source and its
action handlers, and the request that searches or presses a button is never
the request that drew the control. Built lazily per tab, those callbacks
existed only on the renders where nobody needed them — so an action button on
a settings page came back "Unknown action." every single time.
The whole-page set rather than a tab's, because the names are the option name
and the field key with no tab in them, so one covers every tab. It stores
configuration and registers callbacks; the fields themselves are still built
on demand.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tk8y5eZa3CHVVSM6nVxsJw1 parent 9e8229a commit 89d3da9
1 file changed
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
133 | 146 | | |
134 | 147 | | |
135 | 148 | | |
| |||
0 commit comments