-graph updates immediately when smoothing value changes

-updates test to run on Windows

Author: roasterdave

src/artisanlib/curves.py

@@ -352,13 +352,13 @@ def __init__(self, parent:QWidget, aw:'ApplicationWindow', activeTab:int = 0) ->
         self.DeltaETfilter.setRange(0,40)
         self.DeltaETfilter.setAlignment(Qt.AlignmentFlag.AlignRight)
         self.DeltaETfilter.setValue(int(round((self.aw.qmc.deltaETfilter - 1)/2)))
-        self.DeltaETfilter.editingFinished.connect(self.changeDeltaETfilter)
+        self.DeltaETfilter.valueChanged.connect(self.changeDeltaETfilter)
         self.DeltaBTfilter = QSpinBox()
         self.DeltaBTfilter.setSingleStep(1)
         self.DeltaBTfilter.setRange(0,40)
         self.DeltaBTfilter.setAlignment(Qt.AlignmentFlag.AlignRight)
         self.DeltaBTfilter.setValue(int(round(self.aw.qmc.deltaBTfilter -1)/2))
-        self.DeltaBTfilter.editingFinished.connect(self.changeDeltaBTfilter)
+        self.DeltaBTfilter.valueChanged.connect(self.changeDeltaBTfilter)
 
         self.OptimalSmoothingFlag = QCheckBox(QApplication.translate('CheckBox', 'Optimal Smoothing Post Roast'))
         self.OptimalSmoothingFlag.setToolTip(QApplication.translate('Tooltip', 'Use an optimal smoothing algorithm (only applicable offline, after recording)'))
@@ -378,7 +378,7 @@ def __init__(self, parent:QWidget, aw:'ApplicationWindow', activeTab:int = 0) ->
         self.Filter.setRange(0,5)
         self.Filter.setAlignment(Qt.AlignmentFlag.AlignRight)
         self.Filter.setValue(int(round((self.aw.qmc.curvefilter - 1)/2)))
-        self.Filter.editingFinished.connect(self.changeFilter)
+        self.Filter.valueChanged.connect(self.changeFilter)
         #filterspikes
         self.FilterSpikes = QCheckBox(QApplication.translate('CheckBox', 'Smooth Spikes'))
         self.FilterSpikes.setChecked(self.aw.qmc.filterDropOuts)

src/test/unitary/plus/test_plus_util.py

@@ -6,6 +6,7 @@
 import datetime
 import os
 import sys
+from pathlib import Path
 import tempfile
 from typing import Any, Dict, Generator
 from unittest.mock import Mock, patch
@@ -951,7 +952,7 @@ def test_set_plus_icon_with_app_style(self) -> None:
         mock_app_style = Mock()
         mock_app_style.pixelMetric.return_value = 48
 
-        with patch('plus.util.getResourcePath', return_value='/path/to/resources'), patch(
+        with patch('plus.util.getResourcePath', return_value=str(Path('/path/to/resources'))), patch(
             'plus.util.QApplication.style', return_value=mock_app_style
         ), patch('plus.util.QIcon') as mock_qicon, patch('plus.util.QSize') as mock_qsize:
 
@@ -964,7 +965,7 @@ def test_set_plus_icon_with_app_style(self) -> None:
             util.setPlusIcon(mock_mbox)
 
             # Assert
-            mock_qicon.assert_called_once_with('/path/to/resources/Icons/plus-notification.svg')
+            mock_qicon.assert_called_once_with(str(Path('/path/to/resources/Icons/plus-notification.svg')))
             mock_qsize.assert_called_once_with(48, 48)
             mock_mbox.setIconPixmap.assert_called_once_with(mock_pixmap)
 
@@ -973,7 +974,7 @@ def test_set_plus_icon_without_app_style(self) -> None:
         # Arrange
         mock_mbox = Mock()
 
-        with patch('plus.util.getResourcePath', return_value='/path/to/resources'), patch(
+        with patch('plus.util.getResourcePath', return_value=str(Path('/path/to/resources'))), patch(
             'plus.util.QApplication.style', return_value=None
         ), patch('plus.util.QIcon') as mock_qicon, patch('plus.util.QSize') as mock_qsize:
 
@@ -986,6 +987,6 @@ def test_set_plus_icon_without_app_style(self) -> None:
             util.setPlusIcon(mock_mbox)
 
             # Assert
-            mock_qicon.assert_called_once_with('/path/to/resources/Icons/plus-notification.svg')
+            mock_qicon.assert_called_once_with(str(Path('/path/to/resources/Icons/plus-notification.svg')))
             mock_qsize.assert_called_once_with(64, 64)  # Default size
             mock_mbox.setIconPixmap.assert_called_once_with(mock_pixmap)

wiki/ReleaseHistory.md

@@ -29,6 +29,7 @@ v3.2.1
   - updates internal PID by adding Advanced Integral Windup Prevention, derivative on measurement calculation (DoM), measurement discontinuity detection, derivative limiting and enhanced setpoint change detection to prevent the derivative kicks and spikes
   - updates libs (scipy, bleak, lxml, pillow)
   - expands automatic test coverage
+  - graph updates immediately when smoothing value changes
 
 * FIXES
   - fixes regression which broke the designer such that points could not be moved ([Discussion #1905](../../../discussions/1905) and [Issue #1916](../../../issues/1916))