Add Kaleido-CSV-Importer feature - #2090
Conversation
|
❌ Build artisan 8774178 (1779) failed (commit 87741784eb by @lxk36) |
|
Thanks for this! Could you please rework this a little?
I will then take it from there |
|
It might also be a good idea to merge this code into src/artisanlib/kaleido.py instead of keeping this in a separate file not to have too many machine specific parts |
|
I’ve already made the requested changes: Removed the test change from README.md |
|
❌ Build artisan 702753a (1781) failed (commit 702753a1cb by @Terracotta-6) |
|
Thanks! The test files are still missing. Please add them. |
|
❌ Build artisan 711cea4 (1783) failed (commit 711cea4ab9 by @Terracotta-6) |
|
Thanks, I take it from here! |
|
Grateful to the Artisan team for merging PR #2090 (Kaleido CSV Importer). Thanks for the great collaboration! |
|
Please test this carefully and report if there are further changes needed. Thanks for your contribution! |
A big thank you to MAKOMO for the dedicated work on this feature! I will run careful and comprehensive tests, and meanwhile, I’ll notify both the official Kaleido team and our large user group to join the collaborative testing process. |
|
official Kaleido CSV test samples Import error Value Error: Import Kaleido CSV: 'utf-8' codec can't decode byte Oxce in position 136: invalid continuation byte |
|
Where to find those official Kaleido CSV test samples? |
Ask the Kaleido official for it |
|
I have no contact to Kaleido official. Sorry. |
No worries at all! I have direct contact with the official Kaleido team. I can provide the latest official sample files, format specifications, and share test results to assist with adapting the feature. Feel free to let me know if any further details are needed! |
|
In the best case you can provide the failing test files, or at least one of them if the issue is the same in those. Alternatively I need detailed debug logs and the back and forth might cost quite some resources on my and your side. Is there anything criticial such that CSV text files of some sample roasts can not be shared? |
|
PR Summary: Fix Chinese Character Encoding Issue in Kaleido CSV Import Problem Description Changes Made
Resolution Effects
✦ Technical Details
|
|
Sounds ok, but please use a separate PR against the current trunk! |
Added an import tool for Kaleido format CSV files, file path: src/artisanlib/kaleido_csv_importer.py.