Discover Maven and JDK 25 when they are not on PATH - #695
Open
AMDphreak wants to merge 1 commit into
Open
Conversation
…tall when they are not on PATH. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi! On Windows, a PATH-only Maven lookup fails even when Maven is installed. This repo does not ship
mvnw, and a packaged JDK 24 (Adoptium, for example) is often on PATH while the project wants JDK 25.This PR tries to make
scripts/afx-run.ps1andscripts/afx-run.shfind tools for this project:mvnw/mvnw.cmd), if someone adds one latermise which mvnwhenmise.tomlexists and mise is installed; sdkman candidates when.sdkmanrcexistsCODE_ROOT/C:\code/Z:\code→tools/apache-maven-*andtools/jdk-25)mvnon PATH lastUsing: ...(andJAVA_HOME) so the next failure is obviousHive paths are a fallback, not a hard dependency. The scripts do not download Maven and do not add a wrapper binary tree.
Happy to adjust anything that doesn't fit the project's taste.
Fixes #694
How to try it
Get-Command mvnempty) and, if you have one, put Maven undertools/apache-maven-3.9.6of your code hive — or rely on mise / sdkman / PATH..\scripts\afx-run.ps1or./scripts/afx-run.sh.spring-boot:runfinishes if you only wanted the lookup.Made with Cursor