Inconsistent option `error?` vs `not_found_error?` for `Ash.get()` vs `get? true` in action?

[StephanH90]

Code of Conduct

• I agree to follow this project's Code of Conduct

AI Policy

• I agree to follow this project's AI Policy, or I agree that AI was not used while creating this issue.

Versions

Ash: 3.15

Operating system

ubuntu

Current Behavior

I'm not sure it's a bug or by design but I noticed that the options for "don't return an error if no record is found" is different between Ash.get vs a read action with get? true:

# Using Ash.get():
Ash.get(SomeResource, error?: false) # <-- here its `error?`

# Using a read action in a resource:
defmodule MyResource do
  actions do
    read :some_action do
      get? true
    end
  end
end

MyResource.some_action(not_found_error?: false) # <-- here its `not_found_error?`

They seem to be doing the same thing, so shouldn't they use the same option?

Reproduction

No response

Expected Behavior

No response

[zachdaniel]

Hmm....yeah I think that's a good point. Best bet would be to add a not_found_error? option to Ash.get for now, and add a note in the docs that error?: false will be removed in 4.0. Its only known at runtime when its used, so I'd rather not make it warn considering this would generate tons of logs for users.

[RetroDev256]

This issue no longer requires a PR, though it should probably remain open until 4.0 so we are reminded to remove the deprecated code.

[zachdaniel]

Good call!

[zachdaniel]

Good call!