Skip to content

Commit 01b9a88

Browse files
committed
Enable warnings as errors
1 parent 749e7f7 commit 01b9a88

5 files changed

Lines changed: 21 additions & 11 deletions

File tree

.github/workflows/ci.yml

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ jobs:
5353
cxxstd: 17,20
5454
os: ubuntu-24.04
5555
install: g++-13
56+
- compiler: g++-14
57+
cxxstd: 17,20,23
58+
os: ubuntu-24.04
59+
install: g++-14
5660
- compiler: clang++-6.0
5761
cxxstd: 17
5862
os: ubuntu-latest
@@ -115,16 +119,24 @@ jobs:
115119
cxxstd: 17,20,23
116120
os: ubuntu-24.04
117121
install: clang-18
122+
- compiler: clang++-19
123+
cxxstd: 17,20,23
124+
os: ubuntu-24.04
125+
install: clang-19
126+
- compiler: clang++-20
127+
cxxstd: 17,20,23
128+
os: ubuntu-24.04
129+
install: clang-20
118130
# macos
119-
- compiler: clang++
120-
os: macos-13
121-
cxxstd: 17,20
122131
- compiler: clang++
123132
os: macos-14
124133
cxxstd: 17,20
125134
- compiler: clang++
126135
os: macos-15
127136
cxxstd: 17,20,23
137+
- compiler: clang++
138+
os: macos-26
139+
cxxstd: 17,20,23
128140

129141
runs-on: ${{matrix.os}}
130142
container:

CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@ target_include_directories(lazycsv INTERFACE include/)
1414

1515
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
1616

17-
if(MSVC)
18-
add_compile_options(/W4)
19-
elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
20-
add_compile_options(-Wall -Wfatal-errors -Wextra -Wnon-virtual-dtor -pedantic)
21-
endif()
22-
2317
# Install headers
2418
install(DIRECTORY "${CMAKE_SOURCE_DIR}/include/"
2519
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}

test/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@ add_executable(main main.cpp)
22

33
target_link_libraries(main lazycsv)
44

5+
if(MSVC)
6+
add_compile_options(/W4 /WX)
7+
elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
8+
add_compile_options(-Wall -Wfatal-errors -Wextra -Wnon-virtual-dtor -pedantic -Werror)
9+
endif()
10+
511
target_include_directories(main SYSTEM PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/doctest)
612

713
add_custom_command(

tools/run-clang-format.sh

Lines changed: 0 additions & 1 deletion
This file was deleted.

tools/run-clang-tidy.sh

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)