chore: migrate to eslint 10 flat config

eslint.config.js

@@ -0,0 +1,39 @@
+'use strict';
+
+const eslint = require('@eslint/js');
+const { defineConfig } = require('eslint/config');
+const globals = require('globals');
+
+module.exports = defineConfig(
+  {
+    ignores: ['build/**'],
+  },
+  eslint.configs.recommended,
+  {
+    languageOptions: {
+      sourceType: 'commonjs',
+      globals: {
+        ...globals.node,
+      },
+    },
+    rules: {
+      curly: ['error', 'multi-line'],
+      'no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          caughtErrorsIgnorePattern: '^_',
+        },
+      ],
+    },
+  },
+  {
+    files: ['test/**/*.js'],
+    languageOptions: {
+      globals: {
+        ...globals.mocha,
+      },
+    },
+  },
+);

lib/BoundCluster.js

@@ -229,8 +229,11 @@ class BoundCluster {
    * @param {number} [options.startValue=0]
    * @param {number} [options.maxResults=250]
    * @returns {Promise<DiscoverAttributesResponse>}
+   *
+   * TODO: paginate. startValue and maxResults are ignored, so every call answers with all
+   * attributes and lastResponse true, whatever the device asked for.
    */
-  async discoverAttributes({ startValue = 0, maxResults = 250 } = {}) {
+  async discoverAttributes({ startValue: _startValue = 0, maxResults: _maxResults = 250 } = {}) {
     const attributes = Object.values(this.cluster.attributesById)
       .filter(attr => attr.type instanceof ZCLDataType && getPropertyDescriptor(this, attr.name));
 
@@ -263,8 +266,11 @@ class BoundCluster {
    * @param {number} [options.startValue=0]
    * @param {number} [options.maxResults=250]
    * @returns {Promise<DiscoverAttributesExtendedResponse>}
+   *
+   * TODO: paginate. startValue and maxResults are ignored, so every call answers with all
+   * attributes and lastResponse true, whatever the device asked for.
    */
-  async discoverAttributesExtended({ startValue = 0, maxResults = 250 } = {}) {
+  async discoverAttributesExtended({ startValue: _startValue = 0, maxResults: _maxResults = 250 } = {}) {
     const attributes = Object.values(this.cluster.attributesById)
       .filter(attr => attr.type instanceof ZCLDataType && getPropertyDescriptor(this, attr.name));
 
@@ -347,10 +353,8 @@ class BoundCluster {
         debug(this.logId, 'received command', command.name, args);
         const result = await this[command.name](args, meta, frame, rawFrame);
         if (command.response && command.response.args) {
-          // eslint-disable-next-line new-cap
           return [command.response.id, new command.response.args(result), command.response];
         }
-        // eslint-disable-next-line consistent-return
         return;
       }
     }
@@ -359,14 +363,14 @@ class BoundCluster {
   }
 
   // TODO: implement when needed
-  async writeAttributesAtomic(args) {
+  async writeAttributesAtomic(_args) {
     throw new Error('not_implemented');
     // TODO: actually make atomic, capture current state of attrs, exec and restore upon failure
     // return writeAttributesAtomic(args);
   }
 
   // TODO: implement when needed
-  async writeAttributesNoResponse(args) {
+  async writeAttributesNoResponse(_args) {
     throw new Error('not_implemented');
     // TODO: actually disable response
     // return writeAttributesAtomic(args);
@@ -396,7 +400,7 @@ class BoundCluster {
 
   // TODO: implement when needed
   async readReportingConfiguration({
-    attributes = {
+    attributes: _attributes = {
       // direction,
       // attributeId,
     },
@@ -407,7 +411,7 @@ class BoundCluster {
 
   // TODO: implement when needed
   async readAttributesStructured({
-    attributes = [{
+    attributes: _attributes = [{
       // attributeId,
       // indexPath,
     }],
@@ -418,7 +422,7 @@ class BoundCluster {
 
   // TODO: implement when needed
   async writeAttributesStructured({
-    attributes = [{
+    attributes: _attributes = [{
       // attributeId,
       // indexPath,
       // dataTypeId,

lib/Cluster.js

@@ -511,7 +511,6 @@ class Cluster extends EventEmitter {
    */
   async configureReporting(attributes = {}, opts) {
     const req = [];
-    // eslint-disable-next-line guard-for-in,no-restricted-syntax
     for (const attributeName in attributes) {
       const attr = this.constructor.attributes[attributeName];
       if (!attr) throw new TypeError(`${attributeName} Does not exist (${this.constructor.name})`);
@@ -809,10 +808,8 @@ class Cluster extends EventEmitter {
       if (handler) {
         const response = await handler.call(this, args, meta, frame, rawFrame);
         if (command.response && command.response.args) {
-          // eslint-disable-next-line new-cap
           return [command.response.id, new command.response.args(response), command.response];
         }
-        // eslint-disable-next-line consistent-return
         return;
       }
     }
@@ -991,7 +988,6 @@ class Cluster extends EventEmitter {
    */
   static removeCluster(clusterIdOrName) {
     if (this.clusters[clusterIdOrName]) {
-      // eslint-disable-next-line no-shadow
       const Cluster = this.clusters[clusterIdOrName];
       delete this.clusters[Cluster.NAME];
       delete this.clusters[Cluster.ID];
@@ -1089,7 +1085,6 @@ class Cluster extends EventEmitter {
       return r;
     }, {});
 
-    // eslint-disable-next-line guard-for-in,no-restricted-syntax
     for (const cmdName in commands) {
       Object.defineProperty(proto, cmdName, {
         value: {
@@ -1220,7 +1215,6 @@ class Cluster extends EventEmitter {
               if (response.status !== 'SUCCESS') {
                 throw new Error(response.status);
               }
-              // eslint-disable-next-line consistent-return
               return;
             }
 

lib/Endpoint.js

@@ -245,7 +245,7 @@ class Endpoint extends EventEmitter {
     if (!success && typeof status === 'string') {
       try {
         ZCLDataTypes.enum8Status.toBuffer(responseFrame.data, status, 1);
-      } catch (err) {
+      } catch {
         // Ignore invalid status codes and keep the default FAILURE status.
       }
     }

lib/Node.js

@@ -101,7 +101,6 @@ class Node extends EventEmitter {
    */
   async handleFrame(endpointId, clusterId, frame, meta) {
     if (!Buffer.isBuffer(frame)) {
-      // eslint-disable-next-line prefer-rest-params
       debug(`${this.getLogId(endpointId, clusterId)}, invalid frame received`, arguments, frame);
       return;
     }

lib/util/index.js

@@ -5,7 +5,6 @@ const debug = require('debug')('zigbee-clusters');
 function getPropertyDescriptor(obj, name) {
   if (!obj) return;
 
-  // eslint-disable-next-line consistent-return
   return Object.getOwnPropertyDescriptor(obj, name)
     || getPropertyDescriptor(Object.getPrototypeOf(obj), name);
 }

lib/zclFrames.js

@@ -184,7 +184,6 @@ const ZCLConfigureReportingRecords = ({ withStatus } = {}) => new ZCLDataType(
         continue;
       }
 
-      // eslint-disable-next-line default-case
       switch (direction) {
         // Only if the direction is 'reported' are the minInterval/maxInterval and minChange
         // properties available

lib/zclTypes.js

@@ -6,7 +6,6 @@ const ZCLDataType = DataType;
 const ZCLDataTypes = DataTypes;
 const ZCLStruct = Struct;
 
-/* eslint-disable */
 ZCLDataTypes.enum8Status = ZCLDataTypes.enum8({
     SUCCESS                     : 0x00,
     FAILURE                     : 0x01,
@@ -44,7 +43,6 @@ ZCLDataTypes.enum8Status = ZCLDataTypes.enum8({
     CALIBRATION_ERROR           : 0xc2,
     UNSUPPORTED_CLUSTER         : 0xc3,
 });
-/* eslint-enable */
 
 module.exports = {
   ZCLDataTypes,