feat: use BuilderConfig POST for Gloas block production - #323
Draft
AntiD2ta wants to merge 3 commits into
Draft
Conversation
Use the pinned Gloas POST request contract with generated BuilderConfig codecs, negotiated JSON or SSZ transport, and validated response commitments. Files: API proposal and publication options; Gloas BuilderConfig types/codegen; HTTP production, integrity, and transport tests. Validation: focused protocol tests, API/spec/mock/multi/root tests, build, code generation stability, and live Prysm JSON/SSZ decoding passed. Full suite has unrelated legacy JSON error-string failures; golangci-lint lacks its configured attgo plugin.
AntiD2ta
changed the title
Restore the POST response-body bound. post() was changed to pass a zero limit, which readResponseBody treats as "unbounded", so every POST endpoint but block production went back to an unbounded io.ReadAll -- undoing 90e1f9e. maxEPBSResponseSize keeps its 64MiB value for those and for the four ePBS fetch endpoints that share it; block production passes its own, much larger, limits under their own names. Accept an empty builders list. The pinned contract documents an empty list as a valid request ("Empty means request none, so only p2p bids are considered", and a local-preferred build is requested with an empty list and builder_boost_factor 0), with maxItems 64 and no minimum. A nil slice said the same thing but was refused, while an empty non-nil slice was accepted; the underlying defect was MarshalJSON emitting "builders":null for a nil slice, which the required array -- and this package's own decoder -- reject. Complete BuilderConfig YAML support. BuilderEntry, SignedBuilderRequestAuth and BuilderRequestAuth had no MarshalYAML, so a config with any builder in it serialised reflection-derived keys and raw byte arrays; BuilderConfig had no UnmarshalYAML, so a round trip silently dropped min_bid and builder_boost_factor. The URL needs an explicitly quoted scalar: goccy emits "https://..." plain, and the embedded colon makes the enclosing flow document re-parse it as a nested mapping. The existing test only marshalled an empty builders list, so it saw none of this. Restore TestVersionedEPBSProposalProposerIndex, TestVersionedEPBSProposalRoot and the BodyRoot BeaconBlockBodyRootUnset subtest, which were deleted, leaving ProposerIndex() and Root() untested. Root() is what the envelope-matches-block guard and a proposer's signature both rest on. Also: drop the redundant Value test that duplicated a table case and reattach the doc comment it had orphaned, use errors.New for the constant-string fmt.Errorf calls, and collapse the single-case table-driven tests to direct assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch Gloas
produceBlockV4to the POST contract. Requests carry a requiredBuilderConfigand negotiate JSON or SSZ. Responses retain builder routing metadata and reject inconsistent payload contents.Review guide
Start with
http/epbsproposal.go. It builds the POST request, selects the response codec, and checks the block, envelope, builder index, and execution-request commitments.spec/gloas/builderconfig.goand its generated SSZ files define the request types.builderconfig_json.gohandles JSON encoding and bounds checks.api/epbsproposalopts.go,api/versionedepbsproposal.go, andapi/submitproposalopts.goshow the public changes.Behaviour
include_payload=true.Eth-Builder-Urlis retained in response metadata and may be sent when publishing the signed block.Validation
go generate ./spec/gloasgosilent test ./api ./spec/gloasgo build ./...393e9b3c8c7b58bee90da9ae03d0f89988427afb