Remove prompt orchestrator documentation - #1377
Conversation
|
⏳ Code review in progress. Analyzing for code quality issues and best practices. Detailed findings will be posted upon completion. Using Amazon Q Developer for GitHubAmazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation. Slash Commands
FeaturesAgentic Chat Code Review CustomizationYou can create project-specific rules for Amazon Q Developer to follow:
Example rule: FeedbackTo provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository. For more detailed information, visit the Amazon Q for GitHub documentation. Footnotes
|
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Excellent Cleanup Work
This PR effectively completes the cleanup started in PR #1355 by removing all orphaned documentation and procedures for the deleted prompt orchestrator system. The changes demonstrate good systems stewardship principles.
Key Strengths
Thorough Documentation Cleanup: Removes 149 lines of obsolete documentation that referenced deleted systems, preventing future confusion and maintenance overhead.
Consistent Architecture Alignment: Updates the gitignore documentation example to reference current systems (mlruns/) instead of deleted ones (.claude/command-templates), maintaining educational value while reflecting reality.
Clear Intent and Context: The PR description provides excellent context about what was removed, why it was orphaned, and how the current system works differently.
Impact Assessment
- ✅ Zero functional impact - all removed content referenced deleted systems
- ✅ Improved maintainability - eliminates stale documentation that could mislead developers
- ✅ Better developer experience - cleaner docs structure without dead references
This cleanup exemplifies the "subtraction-creates-value" principle mentioned in the PR. The removal of obsolete documentation makes the remaining documentation more valuable and trustworthy.
Recommendation: Approve and merge. This is exactly the kind of proactive maintenance that prevents technical debt accumulation.
| - **Never let a crisis go to waste**: Each failure becomes input for stronger procedures and prevention systems | ||
| - **Leave cookie crumbs**: Document architectural decisions inline where future engineers encounter them. Git commit messages fade into history; inline comments create discoverable breadcrumbs for faster resolution. | ||
| - **Gitignore as architectural documentation**: Every gitignore entry embeds meaning about system structure. `# Setup-generated symlinks (avoid duplicating tracked content)` tells the story of why `.claude/command-templates` exists. Each line is a clue to underlying architecture, not just file exclusion. | ||
| - **Gitignore as architectural documentation**: Every gitignore entry embeds meaning about system structure. `# MLflow experiment tracking data (regenerated on each run)` tells the story of why `mlruns/` is excluded. Each line is a clue to underlying architecture, not just file exclusion. |
There was a problem hiding this comment.
Good update to keep the documentation example current and relevant. The change from .claude/command-templates (deleted system) to mlruns/ (current MLflow tracking) maintains the educational value of the example while reflecting the actual architecture.
Remove all documentation, procedures, and vestigial syntax for the prompt orchestrator system deleted in PR #1355 (Oct 9, 2025). The entire template generation architecture was replaced by Claude Code's native plugin system. ## Files Removed **Documentation (obsolete):** - `docs/prompt-orchestration.md` - Described template syntax for deleted orchestrator - `docs/prompt-orchestrator-security.md` - Security docs for deleted code **Procedure (obsolete):** - `knowledge/procedures/command-lifecycle-management.md` - Referenced deleted tools: - utils/sync-claude-commands.sh (removed PR #1355) - utils/generate-commands.sh (removed PR #1355) - .claude/command-templates/ (never existed) **Artifacts (untracked):** - `utils/__pycache__/prompt_orchestrator.cpython-312.pyc` - Not in git, removed manually ## Vestigial Syntax Removed **commands/close-issue.md** - Removed 2 non-functional markers: - Line 52: `{{ INJECT:principles/tracer-bullets.md }}` - Line 69: `{{ INJECT:principles/eager-evolution.md }}` **commands/extract-best-frame.md** - Removed 1 non-functional marker: - Line 211: `{{ INJECT:principles/tracer-bullets.md }}` These `{{ INJECT: }}` markers were remnants of the deleted orchestrator's template processing. They're not processed by any current system - GitHub Actions only processes `{{ KNOWLEDGE_BASE }}` and local commands don't process them at all. The principles are already available in context, making these markers vestigial documentation cruft. ## Updated **knowledge/principles/systems-stewardship.md:26** - Updated gitignore example: - Old: Referenced deleted `.claude/command-templates` - New: References current `mlruns/` (MLflow tracking data) ## Context The prompt orchestrator (utils/prompt_orchestrator.py) was removed in commit 688fe9d along with 1,131 lines of template generation tooling. These docs and syntax markers were orphaned but not removed at the time. ## Impact - 3 docs files removed (~150 lines) - 1 procedure removed (42 lines) - 3 vestigial syntax markers removed - 1 principle example updated - Zero functional loss - all referenced deleted systems or non-functional syntax Related to #1355 (orchestrator removal) Related to #1352 (plugin system replacement) Principle: subtraction-creates-value
9c4c56a to
1651046
Compare
1 participant
Summary
Remove all orphaned documentation and procedures for the prompt orchestrator system deleted in PR #1355.
Files Removed
Documentation (Obsolete)
✂️ docs/prompt-orchestration.md (42 lines)
{{ INJECT: }},{{ VARIABLE }})utils/prompt_orchestrator.py.claude/command-templates/✂️ docs/prompt-orchestrator-security.md (65 lines)
test_prompt_security.pyProcedure (Obsolete)
utils/sync-claude-commands.sh(deleted PR chore: remove obsolete template generation system #1355)utils/generate-commands.sh(deleted PR chore: remove obsolete template generation system #1355).claude/command-templates/(never existed)Artifacts (Untracked)
Total: ~150 lines of dead documentation removed
Updated
systems-stewardship.md:26
Updated gitignore documentation example:
.claude/command-templatesmlruns/(MLflow tracking data)Context
Original Removal (Oct 9, 2025)
PR #1355 (commit 688fe9d) removed the entire template generation system:
utils/prompt_orchestrator.py(393 lines)Why Documentation Remained
The orchestrator docs and dependent procedure were missed during the initial cleanup, creating orphaned references to deleted tooling.
Replacement System
{{ INJECT: }}syntax.claude-plugin/toknowledge/procedures/Impact
Related
Principle:
subtraction-creates-value