fix: support multiple numeric types for t_id in document. - #161
Merged
Conversation
json unmarshals numbers as float64 in map[string]any, causing type assertion failures when checking t_id as uint32. this fix adds support for float64, int, and string types for t_id parameter, making the api compatible with javascript/json clients where numbers don't have explicit integer types.
test cases cover uint32, float64, int, and string types for t_id parameter, as well as invalid types like bool, slice, and non-numeric strings.
Contributor
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Shell |  |
Aug 3, 2026 6:47a.m. | Review ↗ |
| Java | |
Aug 3, 2026 6:47a.m. | Review ↗ |
| JavaScript | |
Aug 3, 2026 6:47a.m. | Review ↗ |
| Go | |
Aug 3, 2026 6:47a.m. | Review ↗ |
| Secrets | |
Aug 3, 2026 6:47a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
auula
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
auula
added a commit
that referenced
this pull request
Aug 3, 2026
* fix: support multiple numeric types for t_id in updaterows. json unmarshals numbers as float64 in map[string]any, causing type assertion failures when checking t_id as uint32. this fix adds support for float64, int, and string types for t_id parameter, making the api compatible with javascript/json clients where numbers don't have explicit integer types. * test: add unit tests for t_id type support in updaterows. test cases cover uint32, float64, int, and string types for t_id parameter, as well as invalid types like bool, slice, and non-numeric strings. -- amazon krio bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.