fix: Address PR #186 review comments #15-19

Issue #15 & #16: Add @IgnoreIf for Maven availability
- Added @IgnoreIf annotation to skip tests when Maven not configured
- Tests require maven.home system property or MAVEN_HOME environment variable
- Prevents test failures on machines without Maven or network access

Issue #17: Fix typo 'occured' -> 'occurred'
- Fixed typo in FlowErrorHandlerRuleTest error message

Issue #18: Remove onlyIf from generateGDSL task
- Removed onlyIf predicate that could cause stale GDSL output
- Now relies on Gradle's inputs/outputs up-to-date checking only

Issue #19: Add system property cleanup in EffectivePomIntegrationTest
- Added testApp.cleanup() call before testApp.remove() to restore system properties
- Prevents state leakage to subsequent tests

All fixes verified with successful build.

Author: adesjardin

mule-linter-core/build.gradle

@@ -24,16 +24,10 @@ tasks.register('generateGDSL', JavaExec) {
     classpath += sourceSets.main.compileClasspath
     classpath += sourceSets.main.runtimeClasspath
 
-    // Incremental build - only run if template changes
+    // Incremental build - rely on Gradle inputs/outputs up-to-date checking
     inputs.file(templateFile)
     inputs.dir(sourceSets.main.groovy.srcDirs)
     outputs.file(outputGdslFile)
-    
-    // Only run when explicitly requested or when inputs change
-    onlyIf {
-        !outputGdslFile.exists() || 
-        templateFile.lastModified() > outputGdslFile.lastModified()
-    }
 }
 
 // Wire GDSL generation to jar task (only runs if onlyIf condition is met)

mule-linter-core/src/test/groovy/com/avioconsulting/mule/linter/model/EffectivePomIntegrationTest.groovy

@@ -14,12 +14,18 @@ import com.avioconsulting.mule.linter.rule.pom.PomDependencyVersionRule
 import com.avioconsulting.mule.linter.rule.pom.PomExistsRule
 import com.avioconsulting.mule.linter.rule.pom.PomPluginAttributeRule
 import com.avioconsulting.mule.linter.rule.pom.PomPropertyValueRule
+import spock.lang.IgnoreIf
 import spock.lang.Specification
 
 /**
  * Integration tests for effective POM resolution with parent POM inheritance.
  * Tests comprehensive parent-child sample for end-to-end validation of POM rules.
+ * 
+ * NOTE: These tests require Maven to be available (maven.home system property or 
+ * MAVEN_HOME environment variable) and network access to resolve parent POMs.
+ * Tests are skipped if Maven is not configured.
  */
+@IgnoreIf({ !System.getProperty('maven.home') && !System.getenv('MAVEN_HOME') })
 @SuppressWarnings(['MethodName', 'MethodReturnTypeRequired', 'StaticFieldsBeforeInstanceFields'])
 class EffectivePomIntegrationTest extends Specification {
 
@@ -30,6 +36,8 @@ class EffectivePomIntegrationTest extends Specification {
     }
 
     def cleanup() {
+        // Restore system properties before removing test app to avoid state leakage
+        testApp.cleanup()
         testApp.remove()
     }
 

mule-linter-core/src/test/groovy/com/avioconsulting/mule/linter/rule/configuration/FlowErrorHandlerRuleTest.groovy

@@ -196,7 +196,7 @@ http://www.mulesoft.org/schema/mule/vm http://www.mulesoft.org/schema/mule/vm/cu
 \t\t<avio-logger:log doc:id="d5eb2fc2-e566-43fe-9a3f-e91426f3fda2" config-ref="topgolf-core-config" message="END: Get records from ACME system" category="${log.category}.examples" doc:name="END" correlation_id="#[correlationId]" logLocationInfo="true" />
 \t\t<error-handler >
 \t\t\t<on-error-continue enableNotifications="true" logException="true" doc:name="On Error Continue" doc:id="51bc12f9-1ec3-42b9-8bc4-90bdac19fa42" >
-\t\t\t\t<avio-logger:log doc:name="Log ERROR" doc:id="7362ee98-b097-4bb5-8ab8-c4329ec10a2a" config-ref="AVIO_Logger_Config" message="'Error occured in the flow"/>
+\t\t\t\t<avio-logger:log doc:name="Log ERROR" doc:id="7362ee98-b097-4bb5-8ab8-c4329ec10a2a" config-ref="AVIO_Logger_Config" message="'Error occurred in the flow"/>
 \t\t\t</on-error-continue>
 \t\t</error-handler>
 \t</flow>