New: Wire DataViews v16 filters into Logs and Redirects REST endpoints

Refs #68. After upgrading @wordpress/dataviews to v16 every field exposes
its type's full operator set, but the REST API only honoured a handful of
scalar `is` filters. Bring the supported columns up to parity and turn off
filtering on the ones we don't want.

Adds a Filter_Mapper that translates DataViews `{field, operator, value}`
entries into BerlinDB query args, plus two custom args (`like_query`,
`range_query`) handled by a `{plural}_query_clauses` filter on the base
model. BerlinDB's native `compare_query` short-circuits without a metadata
sidecar, so numeric ranges are emitted by us. Adds KEY ip / KEY hits on
logs and KEY hits on redirects (table version bumped to 4.0.2).

Author: joel-james

assets/src/hooks/use-logs.js

@@ -14,25 +14,14 @@ import { buildQueryKey } from './persisted-view'
 
 const BASE = '/404-to-301/v1/logs'
 
-/**
- * Local-time `YYYY-MM-DD` for `days` ago (0 = today). Backs the
- * "First seen" preset-range filter — the endpoint's `date_from`
- * expects a plain date string.
- *
- * @param {number} days Days to subtract from today.
- * @return {string} Date in `YYYY-MM-DD`.
- */
-const daysAgoISO = (days) => {
-	const d = new Date()
-	d.setDate(d.getDate() - days)
-	const mm = String(d.getMonth() + 1).padStart(2, '0')
-	const dd = String(d.getDate()).padStart(2, '0')
-	return `${d.getFullYear()}-${mm}-${dd}`
-}
-
 /**
  * Translate a DataViews `view` object into REST query parameters.
  *
+ * `view.filters` is forwarded verbatim as a structured `filters[]`
+ * array. The server-side mapper (`Filter_Mapper::for_logs()`) maps
+ * each `{ field, operator, value }` entry onto the appropriate
+ * BerlinDB clause (`IN`, `NOT IN`, `compare_query`, or a LIKE).
+ *
  * @param {Object} view DataViews view state.
  * @return {Object} Query args for the logs endpoint.
  */
@@ -51,30 +40,21 @@ const viewToQuery = (view) => {
 		query.order = view.sort.direction === 'asc' ? 'asc' : 'desc'
 	}
 
-	// Filters such as `status` come through `view.filters` as
-	// `{ field, operator, value }`. Forward each as a query arg.
 	if (Array.isArray(view.filters)) {
-		view.filters.forEach((filter) => {
-			if (
-				!filter ||
-				!filter.field ||
-				filter.value === undefined ||
-				filter.value === ''
-			) {
-				return
-			}
-
-			// "First seen" is a preset-range filter (its value is a
-			// number of days, see `dateRanges`). DataViews has no date
-			// operator, so we translate the preset into the endpoint's
-			// `date_from` rather than forwarding `created_at` verbatim.
-			if (filter.field === 'created_at') {
-				query.date_from = daysAgoISO(Number(filter.value) || 0)
-				return
-			}
-
-			query[filter.field] = filter.value
-		})
+		const filters = view.filters
+			.filter(
+				(f) =>
+					f &&
+					f.field &&
+					f.operator &&
+					f.value !== undefined &&
+					f.value !== '' &&
+					!(Array.isArray(f.value) && f.value.length === 0),
+			)
+			.map(({ field, operator, value }) => ({ field, operator, value }))
+		if (filters.length > 0) {
+			query.filters = filters
+		}
 	}
 
 	return query

assets/src/hooks/use-redirects.js

@@ -30,16 +30,20 @@ const viewToQuery = (view) => {
 	}
 
 	if (Array.isArray(view.filters)) {
-		view.filters.forEach((filter) => {
-			if (
-				filter &&
-				filter.field &&
-				filter.value !== undefined &&
-				filter.value !== ''
-			) {
-				query[filter.field] = filter.value
-			}
-		})
+		const filters = view.filters
+			.filter(
+				(f) =>
+					f &&
+					f.field &&
+					f.operator &&
+					f.value !== undefined &&
+					f.value !== '' &&
+					!(Array.isArray(f.value) && f.value.length === 0),
+			)
+			.map(({ field, operator, value }) => ({ field, operator, value }))
+		if (filters.length > 0) {
+			query.filters = filters
+		}
 	}
 
 	return query

assets/src/modules/logs/fields.js

@@ -16,18 +16,6 @@ const statusMeta = {
 	2: { slug: 'fixed', icon: published },
 }
 
-// Preset ranges for the "First seen" filter. DataViews has no date
-// operator, so the range is offered as a single-select of relative
-// windows — each value is a day count that `useLogs` turns into the
-// endpoint's `date_from` (0 = today).
-const dateRanges = [
-	{ value: '0', label: __('Today', '404-to-301') },
-	{ value: '7', label: __('Last 7 days', '404-to-301') },
-	{ value: '30', label: __('Last 30 days', '404-to-301') },
-	{ value: '90', label: __('Last 90 days', '404-to-301') },
-	{ value: '365', label: __('Last 12 months', '404-to-301') },
-]
-
 const empty = <span className="d404-empty">{'—'}</span>
 
 /**
@@ -70,6 +58,11 @@ export const fields = [
 		type: 'text',
 		enableGlobalSearch: true,
 		enableSorting: true,
+		// IPs live in a packed VARBINARY column. LIKE / contains over
+		// packed bytes can't match user input, so only exact / IN
+		// operators are exposed — the server packs the value via
+		// `inet_pton()` before comparing.
+		filterBy: { operators: ['is', 'isNot', 'isAny', 'isNone'] },
 		render: ({ item }) => (item.ip ? <Truncate value={item.ip} /> : empty),
 	},
 	{
@@ -78,6 +71,10 @@ export const fields = [
 		type: 'text',
 		enableGlobalSearch: true,
 		enableSorting: false,
+		// User-agent strings are noisy and high-cardinality. The
+		// global search still hits this column; a dedicated DV filter
+		// would just clutter the picker.
+		filterBy: false,
 		render: ({ item }) => (item.ua ? <Truncate value={item.ua} /> : empty),
 	},
 	{
@@ -92,7 +89,9 @@ export const fields = [
 		label: __('Status', '404-to-301'),
 		type: 'integer',
 		elements: statusElements,
-		filterBy: { operators: ['is', 'isNot'] },
+		// Status is an enum: only the membership operators apply.
+		// Excludes the integer defaults (`lessThan`, `between`, …).
+		filterBy: { operators: ['is', 'isNot', 'isAny', 'isNone'] },
 		render: ({ item }) => {
 			const label =
 				statusElements.find((el) => el.value === item.status)?.label ||
@@ -132,10 +131,11 @@ export const fields = [
 		label: __('First seen', '404-to-301'),
 		type: 'datetime',
 		enableSorting: true,
-		// Preset relative-window filter (Today / Last 7 days / …).
-		// `useLogs` maps the chosen day count to `date_from`.
-		elements: dateRanges,
-		filterBy: { operators: ['is'] },
+		// Date columns are sortable but not filterable: DV16's
+		// datetime operator set (`before`, `after`, `inThePast`, …)
+		// would need date_query plumbing on the API that we haven't
+		// committed to yet.
+		filterBy: false,
 		render: ({ item }) =>
 			item.created_at ? (
 				<time dateTime={item.created_at}>
@@ -150,6 +150,7 @@ export const fields = [
 		label: __('Last hit', '404-to-301'),
 		type: 'datetime',
 		enableSorting: true,
+		filterBy: false,
 		render: ({ item }) =>
 			item.updated_at ? (
 				<time dateTime={item.updated_at}>

assets/src/modules/redirects/fields.js

@@ -85,7 +85,8 @@ export const fields = [
 		type: 'integer',
 		elements: redirectTypes,
 		enableSorting: true,
-		filterBy: { operators: ['is', 'isNot'] },
+		// Status codes are an enum — only membership operators apply.
+		filterBy: { operators: ['is', 'isNot', 'isAny', 'isNone'] },
 		// Show the bare status code in the column so it fits the narrow
 		// width; the full label (e.g. "301 — Moved Permanently (SEO)")
 		// stays available on hover.
@@ -105,26 +106,28 @@ export const fields = [
 		label: __('Match', '404-to-301'),
 		type: 'text',
 		elements: matchTypes,
-		filterBy: { operators: ['is', 'isNot'] },
+		filterBy: { operators: ['is', 'isNot', 'isAny', 'isNone'] },
 		render: ({ item }) => findLabel(matchTypes, item.match_type),
 	},
 	{
-		// Filter-only by default (not in `defaultView.fields`), so it
-		// adds a "Destination type" filter without forcing the column
-		// on — the Destination column already shows link vs. page.
 		id: 'target_type',
 		label: __('Destination type', '404-to-301'),
 		type: 'text',
 		elements: targetTypes,
-		filterBy: { operators: ['is', 'isNot'] },
+		// The Destination column already shows link vs. page; an
+		// explicit destination-type filter is more clutter than
+		// signal here, so leave it column-only.
+		filterBy: false,
 		render: ({ item }) => findLabel(targetTypes, item.target_type),
 	},
 	{
 		id: 'is_active',
 		label: __('Status', '404-to-301'),
 		type: 'boolean',
 		elements: activeStates,
-		filterBy: { operators: ['is'] },
+		// `isNot` is collapsed back to `is` (with the flipped bool) on
+		// the server side — see {@see Filter_Mapper::translate()}.
+		filterBy: { operators: ['is', 'isNot'] },
 		render: ({ item }) => {
 			const label = item.is_active
 				? __('Active', '404-to-301')
@@ -158,6 +161,9 @@ export const fields = [
 		label: __('Last hit', '404-to-301'),
 		type: 'datetime',
 		enableSorting: true,
+		// Date columns are sortable but not filterable — see the
+		// matching note in logs/fields.js.
+		filterBy: false,
 		render: ({ item }) =>
 			item.last_hit_at ? (
 				<time dateTime={item.last_hit_at}>
@@ -172,6 +178,7 @@ export const fields = [
 		label: __('Created', '404-to-301'),
 		type: 'datetime',
 		enableSorting: true,
+		filterBy: false,
 		render: ({ item }) =>
 			item.created_at ? (
 				<time dateTime={item.created_at}>
@@ -190,6 +197,9 @@ export const fields = [
 		label: __('Last edited by', '404-to-301'),
 		type: 'text',
 		enableSorting: true,
+		// We don't ship a user-picker for filtering by author; keep
+		// the column sortable but off the filter list.
+		filterBy: false,
 		render: ({ item }) =>
 			item.modified_by_name ? (
 				<span className="d404-modified-by">