refactor: Address pre-GUI hook PR review in the Cinema 4D submitter

Mirror the review fixes applied to the Maya submitter (deadline-cloud-for-maya
PR #437):

- Extract the auto_accept confirm-callback selection into
  _pre_gui_hook_confirm_callback so the branch can be unit-tested headlessly.
  It returns None (run hooks without prompting) when settings.auto_accept is
  enabled, otherwise qt_hook_confirmation(parent).
- Add unit tests for both paths: auto_accept enabled -> None, and
  auto_accept disabled -> the confirmation dialog actually fires
  (QMessageBox.question is invoked, parented to the passed-in window, and a
  "Yes" reply maps to True). The disabled-path test exercises the real
  qt_hook_confirmation callback rather than mocking it out.

The other Maya review items do not require changes here: the pylint
disable on the pre_gui_hooks import and the redundant pyproject version
comment were already removed, C4D's test never used pytest.importorskip,
and deadline exposes no constant for the "settings.auto_accept" config name
(core itself uses the bare string).

Signed-off-by: Leon Li <2182521+leon-li-inspire@users.noreply.github.com>

Author: leon-li-inspire

src/deadline/cinema4d_submitter/cinema4d_render_submitter.py

@@ -940,6 +940,19 @@ def export_to_temp_folder(temp_dir: str, asset_references: AssetReferences) -> N
     asset_references.input_filenames = temp_assets
 
 
+def _pre_gui_hook_confirm_callback(parent):
+    """Choose the confirmation callback for pre-GUI hooks based on the auto_accept setting.
+
+    Returns ``None`` (run hooks without prompting) when ``settings.auto_accept`` is enabled,
+    otherwise the standard Qt confirmation dialog from ``qt_hook_confirmation``. Kept as a small
+    helper so the auto_accept branch can be unit-tested headlessly.
+    """
+    if str2bool(get_setting("settings.auto_accept")):
+        return None
+
+    return qt_hook_confirmation(parent)
+
+
 def _show_submitter(temp_dir: str, parent=None, f=Qt.WindowType.Tool):  # type: ignore[call-overload]
     """
     Creates and returns a submission dialog for rendering jobs.
@@ -1033,17 +1046,14 @@ def on_create_job_bundle_callback(
     # no on-disk job bundle at this point, so hooks are sourced from DEADLINE_HOOKS_DIR only
     # (bundle_dir=None), gated by settings.allow_environment_hooks. The confirmation prompt is
     # skipped when auto_accept is set; otherwise the standard dialog is shown.
-    confirm_callback = (
-        None if str2bool(get_setting("settings.auto_accept")) else qt_hook_confirmation(parent)
-    )
     pre_gui_output = run_pre_gui_hooks(
         PreGuiHookContext(
             bundle_dir=None,
             job_name=render_settings.name,
             submitter_name="cinema4d",
             parameters=dict(shared_parameter_values),
         ),
-        confirm_callback=confirm_callback,
+        confirm_callback=_pre_gui_hook_confirm_callback(parent),
     )
     # RenderSubmitterUISettings has no `.parameters` list, so apply_pre_gui_output routes
     # name/description onto it and every hook parameter into shared_parameter_values.

test/unit/deadline_submitter_for_cinema4d/test_pre_gui_hooks.py

@@ -5,15 +5,24 @@
 ``_show_submitter`` calls deadline-cloud's ``run_pre_gui_hooks`` (env-only, since Cinema 4D has
 no on-disk bundle at pre-GUI time) and then applies the merged output with deadline-cloud's
 generic ``apply_pre_gui_output``. The full submitter needs a running Cinema 4D, so it is
-exercised in the integration suite; here we verify the DCC-relevant contract headless: Cinema
-4D's ``RenderSubmitterUISettings`` has no ``.parameters`` list, so every hook parameter must
-flow to the dialog's shared parameter values (name/description land on the settings object).
+exercised in the integration suite; here we verify the DCC-owned pieces headless:
+
+* ``apply_pre_gui_output`` routes hook output correctly against Cinema 4D's own
+  ``RenderSubmitterUISettings`` — which has no ``.parameters`` list, so every hook parameter must
+  land in the shared parameter values (name/description land on the settings object). This guards
+  against a regression where ``RenderSubmitterUISettings`` gains a ``parameters`` attribute that
+  would misroute hook params.
+* ``_pre_gui_hook_confirm_callback`` honours the ``settings.auto_accept`` setting.
+
 The c4d / Qt modules are stubbed by ``test/unit/deadline_submitter_for_cinema4d/__init__`` so
 the module imports.
 """
 
+from unittest.mock import patch
+
 from deadline.client.ui.pre_gui_hooks import apply_pre_gui_output
 
+from deadline.cinema4d_submitter import cinema4d_render_submitter
 from deadline.cinema4d_submitter.data_classes import RenderSubmitterUISettings
 
 
@@ -81,3 +90,35 @@ def test_partial_output_only_touches_present_keys():
     assert settings.name == "NewName"
     assert settings.description == "keep me"  # not overwritten
     assert shared == {}  # no parameters in output
+
+
+@patch.object(cinema4d_render_submitter, "get_setting", return_value="true")
+def test_confirm_callback_none_when_auto_accept_enabled(mock_get_setting):
+    """With settings.auto_accept enabled, hooks run without a confirmation prompt."""
+    assert cinema4d_render_submitter._pre_gui_hook_confirm_callback(parent=None) is None
+    mock_get_setting.assert_called_once_with("settings.auto_accept")
+
+
+@patch("qtpy.QtWidgets.QMessageBox")
+@patch.object(cinema4d_render_submitter, "get_setting", return_value="false")
+def test_confirmation_dialog_fires_when_auto_accept_disabled(mock_get_setting, mock_msgbox):
+    """With settings.auto_accept disabled, invoking the returned callback actually shows the
+    confirmation dialog (QMessageBox.question), parented to the passed-in window.
+
+    This exercises the real ``qt_hook_confirmation`` callback rather than mocking it out, so it
+    verifies the prompt fires — not merely that a non-None callback was selected. ``run_pre_gui_hooks``
+    invokes ``confirm_callback(sources)`` with the hook sources; an empty list is enough to reach
+    the dialog. The user's answer is mapped from the QMessageBox reply.
+    """
+    mock_msgbox.question.return_value = mock_msgbox.Yes
+
+    callback = cinema4d_render_submitter._pre_gui_hook_confirm_callback(parent="mainwin")
+    assert callback is not None
+
+    result = callback([])  # no hook sources needed to reach the dialog
+
+    assert mock_msgbox.question.call_count == 1
+    # The dialog is parented to the window passed into the submitter.
+    assert mock_msgbox.question.call_args[0][0] == "mainwin"
+    # "Yes" reply → proceed.
+    assert result is True