take screenshots.

Signed-off-by: Karthik Bekal Pattathana <133984042+karthikbekalp@users.noreply.github.com>

Author: karthikbekalp

.github/scripts/xa11y_linux_smoke.py

@@ -23,14 +23,16 @@ def _dump_apps() -> None:
             print(f"Could not dump accessibility tree: {error}")
 
 
-def _save_screenshot() -> None:
+def _save_screenshot(name: str, *, required: bool = False) -> None:
     try:
         artifact_dir = Path(os.environ.get("XA11Y_SMOKE_ARTIFACT_DIR", "/tmp"))
         artifact_dir.mkdir(parents=True, exist_ok=True)
-        path = artifact_dir / "xa11y-linux-smoke.png"
+        path = artifact_dir / f"{name}.png"
         xa11y.screenshot().save_png(str(path))
         print(f"Saved screenshot to {path}")
     except (OSError, xa11y.XA11yError) as error:
+        if required:
+            raise RuntimeError(f"Could not save required screenshot: {error}") from error
         print(f"Could not save screenshot: {error}")
 
 
@@ -62,6 +64,9 @@ def main() -> None:
         if value != MESSAGE:
             raise AssertionError(f"Expected text field value {MESSAGE!r}, got {value!r}")
 
+        time.sleep(0.5)
+        _save_screenshot("xa11y-linux-smoke-dialog", required=True)
+
         ok_button = app.locator("button[name='OK'], button[name='Ok'], button[name='_OK']").first()
         ok_button.wait_visible(timeout=15)
         ok_button.press()
@@ -74,7 +79,7 @@ def main() -> None:
 
         print("PASS: xa11y opened a Linux app, typed text, and closed it.")
     except Exception:
-        _save_screenshot()
+        _save_screenshot("xa11y-linux-smoke-failure")
         _dump_apps()
         raise
     finally:

.github/workflows/xa11y_linux_smoke.yml

@@ -62,10 +62,10 @@ jobs:
           python .github/scripts/xa11y_linux_smoke.py
           BASH
 
-      - name: Upload failure screenshot
-        if: failure()
+      - name: Upload screenshots
+        if: always()
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
         with:
           name: xa11y-linux-smoke
-          path: ${{ runner.temp }}/xa11y-linux-smoke.png
+          path: ${{ runner.temp }}/xa11y-linux-smoke-*.png
           if-no-files-found: ignore