feat: Remember last used shared job settings for job submissions - #235
Conversation
Signed-off-by: Lagos Gonzales <214008711+gianelli-lagos-aws@users.noreply.github.com>
| max_failed_tasks_count: int = field(default=20, metadata={"sticky": True}) | ||
| max_retries_per_task: int = field(default=5, metadata={"sticky": True}) | ||
| limited_max_worker_count: bool = field(default=False, metadata={"sticky": True}) | ||
| max_worker_count: int = field(default=1, metadata={"sticky": True}) |
There was a problem hiding this comment.
I believe here the default should be -1? Also can we add a comment suggesting that it is -1 when there is no max worker count limit?
There was a problem hiding this comment.
Yes! I updated it and added a comment. Thank you!
… in save_sticky_settings Signed-off-by: Lagos Gonzales <214008711+gianelli-lagos-aws@users.noreply.github.com>
Signed-off-by: Lagos Gonzales <214008711+gianelli-lagos-aws@users.noreply.github.com>
| max_retries_per_task: int = field(default=5, metadata={"sticky": True}) | ||
| max_worker_count: int = field( | ||
| default=-1, metadata={"sticky": True} | ||
| ) # -1 indicates no limited max worker count |
There was a problem hiding this comment.
supernit: no limited -> unlimited
karthikbekalp
left a comment
karthikbekalp
left a comment
There was a problem hiding this comment.
The changes look good to me.
This PR requires https://github.com/aws-deadline/deadline-cloud/pull/711/files from deadline cloud to work. Although, adding this should not break the code it would be better if we could merge this once the deadline cloud changes are merged and released.
For example, something like this: https://github.com/aws-deadline/deadline-cloud-for-cinema-4d/pull/180/files where the pyproject.toml needed some updates so that the feature could work.
…ited worker Signed-off-by: Lagos Gonzales <214008711+gianelli-lagos-aws@users.noreply.github.com>
…dline_cloud_changes
Signed-off-by: Lagos Gonzales <214008711+gianelli-lagos-aws@users.noreply.github.com>
78ff391 to
6ebbd22
Compare
|
karthikbekalp
left a comment
karthikbekalp
left a comment
There was a problem hiding this comment.
As the changes are now in as part of: #266 we should be able to merge this PR in.
3 participants
Fixes: < #95 >
What was the problem/requirement? (What/Why)
The fields priority, initial_state , max_failed_tasks_count, max_retries_per_task, and max_worker_count do not have sticky settings which can be inconvenient for the customer.
What was the solution? (How)
What is the impact of this change?
Customers will have settings that are saved and reused between submissions.
How was this change tested?
Have you run the unit tests?
Yes.
0.05s call test/unit/deadline_adaptor_for_cinema4d/Cinema4DAdaptor/test_adaptor.py::TestCinema4DAdaptor_on_cleanup::test_handle_errors_on_error_stdout[Project not found-True]
0.04s call test/unit/deadline_adaptor_for_cinema4d/Cinema4DAdaptor/test_adaptor.py::TestCinema4DAdaptor_on_cleanup::test_handle_errors_on_error_stdout[CRITICAL: Stop [ge_file.cpp(1172)]-False]
============================================================================== 53 passed in 3.90s ============================================================
Have you run the integration tests?
Yes.
94.44s call test/integ/test_cinema4d.py::test_integ[redshift_textured_with_nonascii_characters]
77.32s call test/integ/test_cinema4d.py::test_integ[redshift_textured]
74.20s call test/integ/test_cinema4d.py::test_integ[redshift]
73.27s call test/integ/test_cinema4d.py::test_integ[redshift_takes]
53.66s call test/integ/test_cinema4d.py::test_integ[physical_textured]
======================================================================== 6 passed in 427.19s (0:07:07) ============================
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.