Skip to content

feat: enable Claude PR review - #463

Merged
crowecawcaw merged 1 commit into
mainlinefrom
feature/enable-claude-pr-review
Jun 10, 2026
Merged

feat: enable Claude PR review#463
crowecawcaw merged 1 commit into
mainlinefrom
feature/enable-claude-pr-review

Conversation

@crowecawcaw

@crowecawcaw crowecawcaw commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Enables the automated, advisory Claude PR-review integration in this repository, matching what is already enabled in aws-deadline/deadline-cloud (#1195).

What this adds

Two thin caller workflows under .github/workflows/:

  • claude_pr_review_collect.yml — Stage 1. Runs on pull_request (opened, synchronize). It does no work and records nothing; it exists only so its completion fires the workflow_run event that starts the review stage. It produces no data the review stage trusts.
  • claude_pr_review.yml — Stage 2. Triggered by the collect workflow's completion via workflow_run, so GitHub runs it from the default branch with this repo's secrets — a fork PR cannot alter the review behavior, permissions, or credential setup. Derives the PR number, head SHA, and base SHA from the server-populated workflow_run payload (which a fork cannot forge).

All the actual review logic — Bedrock authentication, the SHA-pinned action, the restricted read-only tool surface, the read-only PR-head checkout, and per-run turn/token/time limits — lives in the shared reusable workflow at aws-deadline/.github/.github/workflows/reusable_claude_pr_review.yml@mainline. These files are thin callers that forward the workflow_run identifiers and the AWS_CLAUDE_PR_REVIEW_ROLE secret.

Prerequisite

The AWS_CLAUDE_PR_REVIEW_ROLE secret (the OIDC role that can mint a Bedrock bearer token) must be configured for this repository for the review stage to run.

Add the two-stage Claude PR-review caller workflows, matching the
integration already enabled in aws-deadline/deadline-cloud (#1195):

- claude_pr_review_collect.yml: Stage 1, runs on pull_request and exists
  only to fire the workflow_run event that starts the review stage. It
  produces no data the review stage trusts.
- claude_pr_review.yml: Stage 2, triggered by the collect workflow's
  completion. Runs from the default branch with this repo's secrets, so a
  fork PR cannot alter review behavior, permissions, or credentials.

All review logic (Bedrock auth, the pinned action, the restricted tool
surface, the read-only PR-head checkout, and per-run limits) lives in the
reusable workflow in aws-deadline/.github; these are thin callers that
forward the workflow_run identifiers and the role-ARN secret.

Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
@crowecawcaw
crowecawcaw requested a review from a team as a code owner June 10, 2026 23:12
@github-actions github-actions Bot added the waiting-on-maintainers Waiting on the maintainers to review. label Jun 10, 2026
@crowecawcaw
crowecawcaw merged commit c73dfeb into mainline Jun 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-maintainers Waiting on the maintainers to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants