chore(deps): update ruff requirement from ==0.15.* to ==0.16.* - #500
chore(deps): update ruff requirement from ==0.15.* to ==0.16.*#500dependabot[bot] wants to merge 1 commit into
Conversation
2e3b9e6 to
9b1ca08
Compare
Updates the requirements on [ruff](https://github.com/astral-sh/ruff) to permit the latest version. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.15.0...0.16.0) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.16.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
6a52a84
9b1ca08 to
6a52a84
Compare
|
|
||
| [tool.ruff.lint] | ||
| # Keep the lint contract stable across Ruff upgrades; expand this set deliberately. | ||
| select = ["E4", "E7", "E9", "F"] |
There was a problem hiding this comment.
Pinning select makes the [tool.ruff.lint.isort] block below (lines 110-114) permanently dead config.
Ruff only applies [tool.ruff.lint.isort] settings when isort rules (I001/I002) are actually selected. They were not in Ruff 0.15's default set, and they are not in ["E4", "E7", "E9", "F"] either — so known-first-party = ["deadline", "openjd"] has never had an effect and, with the select set now explicitly pinned, never will on a future Ruff upgrade.
Before this change the block was only latently inert (a future default-set expansion could have activated it); now it is inert by construction. Worth resolving one way or the other so the config does not imply import-order enforcement that is not happening:
- add
"I"toselectif import sorting is intended to be enforced (note this will likely flag existing files), or - drop the
[tool.ruff.lint.isort]block.
Same situation applies to ignore = ["E501"] on line 108: E501 is not in E4/E7/E9/F, so the ignore is a no-op (line length is handled by black/line-length instead). Harmless, but similarly misleading.
|
This PR creates unnecessary churn across the repo and I'm not sure if its useful. Closing this PR for now. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Updates the requirements on ruff to permit the latest version.
Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
a2635fdBump 0.16.0 (#27136)3433449[ty] Reuse full call diagnostics for implicit setter calls (#27115)2240070Reflectruff: ignoreand--add-ignorestabilization in documentation (#27...17ef711Stabilize--add-ignore(#27125)ef912bbAdd newly stabilized rules to defaults (#27055)b30f040Stabilize new default rules (#27035)bcd70c5Exclude Markdown files fromformat-devruns (#27052)87e51e2Fixformat --checkspans for syntax errors (#27045)afe2723[flake8-gettext] Stabilize qualified-name and built-in binding resolution (...a9702d8[flake8-bandit] Stabilize string literal binding resolution (S310) (#26944)