Skip to content

chore(deps): update ruff requirement from ==0.15.* to ==0.16.* #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

chore(deps): update ruff requirement from ==0.15.* to ==0.16.* #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ ignore_missing_imports = true
line-length = 100

[tool.ruff.lint]
# Keep the lint contract stable across Ruff upgrades; expand this set deliberately.
select = ["E4", "E7", "E9", "F"]

@github-actions github-actions Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning select makes the [tool.ruff.lint.isort] block below (lines 110-114) permanently dead config.

Ruff only applies [tool.ruff.lint.isort] settings when isort rules (I001/I002) are actually selected. They were not in Ruff 0.15's default set, and they are not in ["E4", "E7", "E9", "F"] either — so known-first-party = ["deadline", "openjd"] has never had an effect and, with the select set now explicitly pinned, never will on a future Ruff upgrade.

Before this change the block was only latently inert (a future default-set expansion could have activated it); now it is inert by construction. Worth resolving one way or the other so the config does not imply import-order enforcement that is not happening:

  • add "I" to select if import sorting is intended to be enforced (note this will likely flag existing files), or
  • drop the [tool.ruff.lint.isort] block.

Same situation applies to ignore = ["E501"] on line 108: E501 is not in E4/E7/E9/F, so the ignore is a no-op (line length is handled by black/line-length instead). Harmless, but similarly misleading.

ignore = ["E501"]

[tool.ruff.lint.isort]
Expand Down
2 changes: 1 addition & 1 deletion requirements-testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ mypy == 2.*
pytest == 9.*
pytest-cov == 7.*
pytest-xdist == 3.*
ruff == 0.15.*
ruff == 0.16.*
twine == 7.*
types-pyyaml == 6.*
# for integ tests
Expand Down
Loading