Skip to content

fix: traveres from main take when setting a take for rendering - #509

Merged
leon-li-inspire merged 1 commit into
aws-deadline:mainlinefrom
patrickjahns:fix/issue_when_current_take_is_not_main_take
Aug 7, 2026
Merged

fix: traveres from main take when setting a take for rendering#509
leon-li-inspire merged 1 commit into
aws-deadline:mainlinefrom
patrickjahns:fix/issue_when_current_take_is_not_main_take

Conversation

@patrickjahns

Copy link
Copy Markdown
Contributor

Prior to this change, the user would need to set/activate the main take first before submitting the file to deadline cloud.
If the user did not select the Main/Base take, a take that is a sub-descent from the currently selected take would not be found.

What was the problem/requirement? (What/Why)

Submitting a cinema4d file, where the active/selected take was not the base take of the document would lead to the following failure:

2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT: Performing action: {"name": "take", "args": {"take": "TakeB"}}
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT: Traceback (most recent call last):
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:   File "C:\Python311\Lib\site-packages\deadline\cinema4d_adaptor\Cinema4DClient\plugin\DeadlineCloudClient.pyp", line 30, in PluginMessage
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:     return parse_argv(sys.argv)
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:            ^^^^^^^^^^^^^^^^^^^^
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:   File "C:\Python311\Lib\site-packages\deadline\cinema4d_adaptor\Cinema4DClient\plugin\DeadlineCloudClient.pyp", line 23, in parse_argv
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:     main()
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:   File "C:\Python311\Lib\site-packages\deadline\cinema4d_adaptor\Cinema4DClient\cinema4d_client.py", line 137, in main
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:     client.poll()
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:   File "C:\Python311\Lib\site-packages\openjd\adaptor_runtime_client\base_client_interface.py", line 212, in poll
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:     self._perform_action(action)
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:   File "C:\Python311\Lib\site-packages\openjd\adaptor_runtime_client\base_client_interface.py", line 233, in _perform_action
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:     action_func(a.args)
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:   File "C:\Python311\Lib\site-packages\deadline\cinema4d_adaptor\Cinema4DClient\cinema4d_handler.py", line 388, in set_take
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT:     raise RuntimeError("Take not found: %s" % take_name)
2026/07/31 11:17:04+02:00 ADAPTOR_OUTPUT: STDOUT: RuntimeError: Take not found: TakeB

However - the document contained the take TakeB - though TakeA was selected in the UI when it was saved (and not the main take )

What was the solution? (How)

Perform the check starting from the Base/Main take of a document

What is the impact of this change?

How was this change tested?

Tested on our render farm and run the unit tests

  • Have you run the unit tests?

yes

  • Have you run the integration tests? (Add your integration test report below)

no

  • Have you made changes to the submitter?

no

Was this change documented?

No - no change needed from my opinion

Is this a breaking change?

no

@patrickjahns
patrickjahns requested a review from a team as a code owner August 6, 2026 11:21
Prior to this change, the user would need to set/activate the main take first
before submitting the file to deadline cloud.
If the user did not select the Main/Base take, a take that is a sub-descent from the currently
selected take would not be found.

Signed-off-by: Patrick Jahns <kontakt@patrickjahns.de>
@patrickjahns
patrickjahns force-pushed the fix/issue_when_current_take_is_not_main_take branch from 4b9b0c6 to d963eec Compare August 6, 2026 11:26
@github-actions github-actions Bot added the waiting-on-maintainers Waiting on the maintainers to review. label Aug 7, 2026
@leon-li-inspire
leon-li-inspire enabled auto-merge (squash) August 7, 2026 18:04
@leon-li-inspire
leon-li-inspire merged commit c9d04eb into aws-deadline:mainline Aug 7, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-maintainers Waiting on the maintainers to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants