fix: traveres from main take when setting a take for rendering - #509
Merged
leon-li-inspire merged 1 commit intoAug 7, 2026
Conversation
Prior to this change, the user would need to set/activate the main take first before submitting the file to deadline cloud. If the user did not select the Main/Base take, a take that is a sub-descent from the currently selected take would not be found. Signed-off-by: Patrick Jahns <kontakt@patrickjahns.de>
patrickjahns
force-pushed
the
fix/issue_when_current_take_is_not_main_take
branch
from
August 6, 2026 11:26
4b9b0c6 to
d963eec
Compare
leon-li-inspire
approved these changes
Aug 6, 2026
leon-li-inspire
approved these changes
Aug 7, 2026
leon-li-inspire
enabled auto-merge (squash)
August 7, 2026 18:04
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, the user would need to set/activate the main take first before submitting the file to deadline cloud.
If the user did not select the Main/Base take, a take that is a sub-descent from the currently selected take would not be found.
What was the problem/requirement? (What/Why)
Submitting a cinema4d file, where the active/selected take was not the base take of the document would lead to the following failure:
However - the document contained the take
TakeB- thoughTakeAwas selected in the UI when it was saved (and not the main take )What was the solution? (How)
Perform the check starting from the Base/Main take of a document
What is the impact of this change?
How was this change tested?
Tested on our render farm and run the unit tests
yes
no
no
Was this change documented?
No - no change needed from my opinion
Is this a breaking change?
no