Repository navigation
Conversation
harsh62
marked this pull request as ready for review
October 19, 2026 14:18
harsh62
force-pushed
the
auth/stack-11-consumers-on-auth
branch
from
October 19, 2026 22:38
a1a999b to
cc75d1f
Compare
|
… Auth (stack 11/14)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Moves every private consumer onto
Authbefore anything is deleted.Issue #, if available: see #711
Changes
comprehensivetest app: every auth instance is nowAuth, including the Secret block's gated test methods.Auth, with the deploy done in PlaywrightglobalSetup;native-bindings,amplify-gen2onAuth.fromExisting(no hand-written verifier),vpc-smoke,auth-cognito-passkeys.Auth.AuthCognito0.1.12 →Authmust reachUPDATE_COMPLETEwith the same pool, users and sessions, and the old cookie must still work.What to review closely: These apps are private, so they can import
@aws-blocks/bb-authstraight from the workspace. The deployed e2e builds gate their test-only methods (testSupport: account creation, the admin surface, secret values) behind a secret that is made fresh for each run and passed throughBLOCKS_TEST_SUPPORT_SECRET, so neither CI nor the tests read it from AWS and the CI role needs no new permission (L35, R124). Check that a normal build still has notestSupportnamespace (test-support-synth.test.ts).Validation
This branch passed on its own:
npm ci, with the lockfile unchanged bynpm installlint:depscheck:apichangeset-guardcheckstest:unit: 7,754 passed, 1 failed (main's timing-sensitiveframework-sinktest, which counts shared temp folders; it passes on its own)test:e2e:local(and vendorize): 502 passed, 0 failedswift build, codegen and runtime tests, SwiftFormatThe per-run test-support secret (R124) was proven on AWS too, on new stacks that were destroyed afterwards:
comprehensivesandbox e2e 431/431 with the secret set the way CI sets it, andhosting-spasandbox e2e 11 passed (1 skipped by design) withglobalSetupgenerating it. CloudTrail for the run shows nossm:GetParametercall by the test process, and none on a test-support parameter; the only reads were the stack's own Lambda reading its blocks' secrets.The full stack passed end to end on AWS, on new stacks that were destroyed afterwards: upgrade-in-place from
AuthCognito,comprehensivesandbox and production, hosting, native, and the CloudFront front door (see #711). That run was on the tree before the latest merges ofmain(#824's synth guards, #797's SwiftBlocksentry point, #834's template metadata, #835/#837's native opt-out warnings, #841, #749, #819 and dependency bumps, then #208'ssubmitAuthAction, #807's Swift typed declared-binding results, #637's config-bucket hardening and more dependency bumps); the merged tree, which part 12 is, passed every local gate, including the native suites and the Swift e2e against a local backend.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.