Repository navigation
Conversation
3cc3995 to
260decf
Compare
🦋 Changeset detectedLatest commit: 7b2fbb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦋 Changeset detectedLatest commit: 260decf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
CodeQL alerts on this PR (part 13) #101 Commit: |
…n (L69) (stack 13/14)
Problem
A browser sign-in client for a web app on a different origin than its API (L69, decided by the maintainer: build it, as its own PR).
Issue #, if available: see #711
Changes
createAuthClient()from@aws-blocks/bb-auth/browser-client, also re-exported from@aws-blocks/blocks/ui. Its methods are named after Amplify JS v6:signInWithRedirect,handleSignInRedirect,getCurrentUser,fetchAuthSession,signOut.HttpOnlycookie.GET …/session, and JSON from sign-out.DESIGN.md, andMIGRATION.mdforAuthOIDC'sgetClient().What to review closely: Open: L79. After a provider-side sign-out, the provider returns to the API's origin, not the frontend's. Not yet run against real Cognito managed login.
Validation
Re-cut onto
main@dea4ca20. This branch passed on its own, from a freshnpm ci:npm cichangeset-guard: its tests and all four checkscomprehensive'stsc --noEmittsc --noEmit, matchingmain's baseline: the same five apps fail as onmain(amplify-gen2,extending-blocks-guide,hosting-ssr-nuxt,hosting-ssr-sveltekit,native-bindings), and no otherPart 12's tree, which is the whole stack apart from the stack doc, also passed build,
update:api, the fixture regeneration and the live auth-spec check with zero drift,comprehensive'stsc --noEmit, andnpm test: 8,857 passed, 0 failed.An earlier tree of the full stack passed end to end on AWS, on new stacks that were destroyed afterwards: upgrade-in-place from
AuthCognito,comprehensivesandbox and production, hosting, native, and the CloudFront front door (see #711). That run came before the later merges ofmain(#824's synth guards, #797's SwiftBlocksentry point, #834's template metadata, #835/#837's native opt-out warnings, #841, #749, #819 and dependency bumps, then #208'ssubmitAuthAction, #807's Swift typed declared-binding results, #637's config-bucket hardening and more dependency bumps, then #736's per-namespace RPC paths, #574'sComputeBase, #910's native escaping, #704's KotlinBlocksentry point, #907's Next.js 16, #927's hosting security headers and more, then #1042's sandbox-only stub IdP andgetDeploymentType(), #1032's fail-closed mock entries, #510's swappable hosting front doors, #949, #827, #948's per-namespace compute and more, then this round's #1024, #1050, #1027'sapiWaf, #1076, #962, #902's typedOIDCClient, #674 and more) and before the #856 review fixes.The
bench / summarycheck is not a required check. It currently fails repo-wide, on unrelated PRs too, because of runner isolation.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.