Repository navigation
chore(repo): review fixes for #874: versioning-strategy comment - #992
Merged
Merged
Conversation
Review follow-up: auto already resolves to increase for the root package.json, so the setting pins today's behaviour. Dependabot doesn't read peerDependencies; it only rewrites a peer range identical to the one it bumps (none here), so the aws-cdk-lib/constructs peer floors stay manual.
|
This was referenced Oct 23, 2026
belaboe
merged commit Oct 26, 2026
93c5cac
into
belaboe/dependabot-versioning-increase
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Review follow-up for #874 (comment): the header bullet said
increaseraises the minimum "not only the lockfile", which suggests the previous behaviour was lockfile-only. It wasn't: withauto, Dependabot treats the rootpackage.jsonas an app and already resolves toincrease. The bullet also didn't say that Dependabot never editspeerDependencies.Issue #, if available: stacked on #874 (base:
belaboe/dependabot-versioning-increase).Changes
increasedoes what the ncu job does and pins whatautoalready resolves to here, and theaws-cdk-lib/constructspeer floors stay manual. The peer wording is narrower than "never edited": dependabot-core doesn't readpeerDependencies, but itspackage_json_updater.rbrewrites a peer range that is identical to the one it bumps (no package has such a pair today).versioning-strategy: increaseitself stays, as the maintainers decided: it matches whatncu -u --target minordid.Text for #874's description
Proposed additions to #874's description (this PR doesn't edit it):
Require changesetcheck doesn't block Dependabot PRs once the pending changesets onmainare used up.aws-cdk-lib ^2.257.0,constructs): Dependabot doesn't readpeerDependencies(it only rewrites a peer range identical to the one it bumps, none today), so these floors stay manual while the devDependency copies keep rising. Owner: (to be named by maintainers).increasevsincrease-if-necessary: keepincrease(no change from ncu).Series
Merge order: #873, #874 (this), #935, #875, #977, then #876. #935's header bullet was moved in its review-fix PR, so it no longer conflicts with this one.
Review-fix PRs for the series: #991 (for #873), #992 (#874), #993 (#935), #994 (#875), #995 (#876). Changesets: #977. Migration issue: #984.
Validation
.github/dependabot.ymlvalidates against the SchemaStoredependabot-2.0JSON schema; only a comment changes.git merge-treeagainstmain: clean.Checklist
dependabot.yml)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.