Repository navigation
ci(deps): review fixes for #935: dev majors caveat, hold vite/svelte majors - #993
Merged
Merged
Conversation
Review follow-ups: - while the dev-dependencies group PR is open, Dependabot marks the group's dependencies as handled and opens no PR for their majors (dependabot/dependabot-core#14202). Say so, and name the manual check. - move the header bullet below the typescript/@types/node bullet, so it no longer conflicts with the versioning-strategy bullet from #874.
Review follow-up: SvelteKit 3 and the Vite 8 plugins peer-depend on Vite 8, and SvelteKit 3 on TypeScript 6, so an individual major PR can't resolve. Ignore their majors, like the typescript ones, and track the migration in issue #984.
|
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Review follow-ups for #935:
dev-dependenciesgroup has no open PR. While it has one, Dependabot marks the group's dependencies as handled and opens no PR for their majors (Dependencies matched by group patterns are marked as "handled" regardless of update-types, suppressing major version PRs dependabot/dependabot-core#14202; the fix in Raise individual pull requests for group members that update-types rejects dependabot/dependabot-core#16113 is behind an experiment flag).@sveltejs/kit@3needsvite ^8,typescript ^6and@sveltejs/vite-plugin-svelte ^7;@sveltejs/adapter-node@6needs kit 3), so a single major PR can't resolve.Issue #, if available: stacked on #935 (base:
ci/dependabot-dev-group-minor-patch). Migration tracked in #984.Changes
npm outdated(root and workspaces) before each release catches the rest.vite,@vitejs/*and@sveltejs/*, with a one-line reason, like the existingtypescript/@types/nodeones. The migration (Vite 8, SvelteKit 3, TypeScript 6, and the MPL-2.0lightningcssquestion for scaffolded apps) is tracked in Migrate test apps and templates to Vite 8, SvelteKit 3 and TypeScript 6 #984. This also cuts the burst of individual major PRs the review expected (about 15, sharing the limit of 10 with ungrouped production PRs); who triages the remaining ones is still for the maintainers to name.typescript/@types/nodebullet, so it no longer touches the lines chore(repo): raise package.json minimums in npm Dependabot updates #874 adds. With the series merged in order, both bullets are kept.Series
Merge order: #873, #874, #935 (this), #875, #977, then #876. #977 writes the changeset for Dependabot bumps at release time.
Review-fix PRs for the series: #991 (for #873), #992 (#874), #993 (#935), #994 (#875), #995 (#876). Changesets: #977. Migration issue: #984.
Validation
.github/dependabot.ymlvalidates against the SchemaStoredependabot-2.0JSON schema; an unknownupdate-typesvalue is rejected.git merge-treeagainstmain: clean. The series merged in order ontomain(chore(repo): run npm Dependabot version updates weekly #873, chore(repo): raise package.json minimums in npm Dependabot updates #874, this, chore(repo): add Dependabot version updates for create-blocks-app templates #875, ci(release): write the changeset for Dependabot bumps at release time #977, chore(repo): retire the weekly ncu dependency update job #876 review-fix branches): no conflicts.individual_prs_for_semver_excluded_dependenciesexperiment is on (Deferring to the update-types rules of group 'dev-dependencies'). If it is, the caveat in the bullet can go.Checklist
dependabot.yml)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.