Skip to content

ci(deps): review fixes for #935: dev majors caveat, hold vite/svelte majors - #993

Merged
belaboe merged 2 commits into
ci/dependabot-dev-group-minor-patchfrom
review/935-fixes
Oct 26, 2026
Merged

belaboe merged 2 commits into
ci/dependabot-dev-group-minor-patchfrom
review/935-fixes

Conversation

@belaboe

@belaboe belaboe commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Review follow-ups for #935:

Issue #, if available: stacked on #935 (base: ci/dependabot-dev-group-minor-patch). Migration tracked in #984.

Changes

  • Header bullet uses the reviewer's wording: majors are raised as their own PRs only on runs where the group has no open PR, and plain npm outdated (root and workspaces) before each release catches the rest.
  • Root npm entry ignores semver-major updates of vite, @vitejs/* and @sveltejs/*, with a one-line reason, like the existing typescript / @types/node ones. The migration (Vite 8, SvelteKit 3, TypeScript 6, and the MPL-2.0 lightningcss question for scaffolded apps) is tracked in Migrate test apps and templates to Vite 8, SvelteKit 3 and TypeScript 6 #984. This also cuts the burst of individual major PRs the review expected (about 15, sharing the limit of 10 with ungrouped production PRs); who triages the remaining ones is still for the maintainers to name.
  • The bullet moved below the typescript / @types/node bullet, so it no longer touches the lines chore(repo): raise package.json minimums in npm Dependabot updates #874 adds. With the series merged in order, both bullets are kept.

Series

Merge order: #873, #874, #935 (this), #875, #977, then #876. #977 writes the changeset for Dependabot bumps at release time.

Review-fix PRs for the series: #991 (for #873), #992 (#874), #993 (#935), #994 (#875), #995 (#876). Changesets: #977. Migration issue: #984.

Validation

Checklist

  • PR description included
  • Tests are changed or added (Dependabot config)
  • Relevant documentation is changed or added (header comment in dependabot.yml)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Review follow-ups:
- while the dev-dependencies group PR is open, Dependabot marks the group's
  dependencies as handled and opens no PR for their majors
  (dependabot/dependabot-core#14202). Say so, and name the manual check.
- move the header bullet below the typescript/@types/node bullet, so it no
  longer conflicts with the versioning-strategy bullet from #874.
Review follow-up: SvelteKit 3 and the Vite 8 plugins peer-depend on Vite 8,
and SvelteKit 3 on TypeScript 6, so an individual major PR can't resolve.
Ignore their majors, like the typescript ones, and track the migration in
issue #984.
@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ac06d7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant