Skip to content
This repository was archived by the owner on Dec 31, 2025. It is now read-only.

fix(convert-config): don't skip certificate config if it contains duplicates - #1305

Merged
rycerrat merged 1 commit into
aws-samples:mainfrom
oliviergaumond:convert-config-certificates
Oct 7, 2025
Merged

fix(convert-config): don't skip certificate config if it contains duplicates#1305
rycerrat merged 1 commit into
aws-samples:mainfrom
oliviergaumond:convert-config-certificates

Conversation

@oliviergaumond

@oliviergaumond oliviergaumond commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This fix an issue in convert-config where it could skip generation of the certificates blocks if the original ASEA config used the same certificate name for multiple account or OUs. Will ow display a warning if this occurs

@hickeydh-aws hickeydh-aws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rycerrat
rycerrat merged commit 85956a6 into aws-samples:main Oct 7, 2025
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants