refactor(insight): remove NaN warning

Author: Alex Wang

packages/aws-durable-execution-sdk-python-insight/src/aws_durable_execution_sdk_python_insight/plugin.py

@@ -32,7 +32,6 @@
 
 import datetime
 import json
-import logging
 import math
 import sys
 import threading
@@ -62,9 +61,6 @@
 )
 
 
-logger = logging.getLogger(__name__)
-
-
 # Maps the SDK invocation status onto the record status. A durable execution
 # suspends (PENDING) while waiting; from the execution's point of view it is
 # still in flight, so surface it as RUNNING (mirrors the JS STATUS_MAP).
@@ -118,7 +114,6 @@ def _resolve_sampling_rate(rate: float | None) -> float:
         # False, x < NaN -> False) and silently sample OUT every execution,
         # disabling all instrumentation. Coerce to full sampling instead, which
         # matches the JS plugin's treatment of non-finite/invalid rates.
-        logger.warning("sampling_rate is NaN; falling back to 1.0 (full sampling)")
         return 1.0
     if rate < 0 or rate > 1:
         return max(0.0, min(1.0, float(rate)))

packages/aws-durable-execution-sdk-python-insight/tests/test_plugin.py

@@ -13,7 +13,6 @@
 from __future__ import annotations
 
 import datetime
-import logging
 from typing import Any
 
 from aws_durable_execution_sdk_python.lambda_service import (
@@ -204,19 +203,14 @@ def test_resolve_sampling_rate_nan_fails_open_to_one():
     assert _resolve_sampling_rate(float("nan")) == 1.0
 
 
-def test_nan_sampling_rate_emits_instead_of_silently_disabling(caplog):
+def test_nan_sampling_rate_emits_instead_of_silently_disabling():
     exporter = CaptureExporter()
-    with caplog.at_level(
-        logging.WARNING,
-        logger="aws_durable_execution_sdk_python_insight.plugin",
-    ):
-        plugin = workflow_insight(
-            WorkflowInsightConfig(exporters=[exporter], sampling_rate=float("nan"))
-        )
-        _run(plugin, ops=[_step("greet")])
+    plugin = workflow_insight(
+        WorkflowInsightConfig(exporters=[exporter], sampling_rate=float("nan"))
+    )
+    _run(plugin, ops=[_step("greet")])
     # A NaN rate must not disable instrumentation: the record is still emitted.
     assert len(exporter.records) == 1
-    assert "sampling_rate is NaN" in caplog.text
 
 
 def test_content_omit_input_output_without_drop_flags():