Commit cf4d27f
docs(insight): state HttpExporter timeout_ms scope
The HttpExporter docstring said timeout_ms "bounds the whole request".
It does not: http_send passes it to urllib, which applies it to each
blocking socket operation. An endpoint that stops reading or goes
silent fails at timeout_ms, but one that keeps consuming or sending
bytes slowly can hold the request open for longer (measured in review
of #720: 37 s with timeout_ms=2000 against a 1 byte/s server).
- HttpExporter docstring: name the phases the timeout applies to (the
connect, each write of the request, each read of the status line,
headers, and a non-2xx error body; a 2xx body is never read), note
that a future release may enforce timeout_ms as a whole-request
deadline, and tell callers to size the function timeout with this
in mind
- http_send docstring: same per-operation description
- README HttpExporter section: same caveat and reservation
- rename test_timeout_is_enforced to test_timeout_applies_to_a_silent_peer,
which is the case it exercises; no assertion changed
No behaviour change.1 parent 86ea45c commit cf4d27f
4 files changed
Lines changed: 23 additions & 5 deletions
File tree
- packages/aws-durable-execution-sdk-python-insight
- src/aws_durable_execution_sdk_python_insight/exporters
- tests
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
186 | | - | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
187 | 192 | | |
188 | 193 | | |
189 | 194 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
93 | 97 | | |
94 | 98 | | |
95 | 99 | | |
| |||
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
39 | 48 | | |
40 | 49 | | |
41 | 50 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
184 | | - | |
| 184 | + | |
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| |||
0 commit comments