feat(plugin)!: add execution_start_time to invocation info

Author: nvasiu

packages/aws-durable-execution-sdk-python-otel/src/aws_durable_execution_sdk_python_otel/plugin.py

@@ -320,7 +320,7 @@ def on_invocation_start(self, info: InvocationStartInfo) -> None:
         logger.debug("Durable invocation started: %s", info)
         self._execution_arn = info.execution_arn or ""
         self._extracted_context = self._context_extractor(info)
-        self._id_generator.set_trace_id(self._execution_arn, info.start_time)
+        self._id_generator.set_trace_id(self._execution_arn, info.execution_start_time)
 
         self._start_span(
             operation_id=None,
@@ -331,16 +331,15 @@ def on_invocation_start(self, info: InvocationStartInfo) -> None:
     def on_invocation_end(self, info: InvocationEndInfo) -> None:
         """Called at the end of each invocation. Ends the invocation span and flushes."""
         logger.debug("Durable invocation ended: %s", info)
-        end_time = info.end_time
         # end all pending spans
         with self._operation_spans_lock:
             operation_ids = list(self._operation_spans.keys())
         for operation_id in operation_ids:
             if operation_id:
-                self._end_span(operation_id, end_time)
+                self._end_span(operation_id)
 
         # end the invocation span
-        self._end_span(None, end_time)
+        self._end_span(None)
 
         # Clear all per-invocation state to prevent leaks across warm Lambda reuses
         self._execution_arn = ""

packages/aws-durable-execution-sdk-python-otel/tests/test_log_filter.py

@@ -49,7 +49,7 @@ def _invocation_start_info() -> InvocationStartInfo:
     return InvocationStartInfo(
         request_id="request-1",
         execution_arn=EXECUTION_ARN,
-        start_time=START_TIME,
+        execution_start_time=START_TIME,
         is_first_invocation=True,
     )
 

packages/aws-durable-execution-sdk-python-otel/tests/test_plugin.py

@@ -70,7 +70,7 @@ def _invocation_start_info() -> InvocationStartInfo:
     return InvocationStartInfo(
         request_id="request-1",
         execution_arn=EXECUTION_ARN,
-        start_time=START_TIME,
+        execution_start_time=START_TIME,
         is_first_invocation=True,
     )
 
@@ -80,10 +80,9 @@ def _invocation_end_info() -> InvocationEndInfo:
     return InvocationEndInfo(
         request_id="request-1",
         execution_arn=EXECUTION_ARN,
-        start_time=START_TIME,
+        execution_start_time=START_TIME,
         is_first_invocation=True,
         status=InvocationStatus.SUCCEEDED,
-        end_time=END_TIME,
         error=None,
     )
 

packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/plugin.py

@@ -161,8 +161,8 @@ def from_start_info(
 class InvocationInfo:
     request_id: str | None
     execution_arn: str | None
-    start_time: datetime.datetime | None
     is_first_invocation: bool
+    execution_start_time: datetime.datetime | None = None
 
 
 @dataclass(frozen=True)
@@ -172,9 +172,8 @@ class InvocationStartInfo(InvocationInfo):
 
 @dataclass(frozen=True)
 class InvocationEndInfo(InvocationInfo):
-    status: InvocationStatus
-    end_time: datetime.datetime | None
-    error: ErrorObject | None
+    status: InvocationStatus | None = None
+    error: ErrorObject | None = None
 
     @classmethod
     def from_durable_execution_invocation_output(
@@ -185,10 +184,9 @@ def from_durable_execution_invocation_output(
         return InvocationEndInfo(
             request_id=invocation_start_info.request_id,
             execution_arn=invocation_start_info.execution_arn,
-            start_time=invocation_start_info.start_time,
             is_first_invocation=invocation_start_info.is_first_invocation,
+            execution_start_time=invocation_start_info.execution_start_time,
             status=output.status,
-            end_time=datetime.datetime.now(datetime.UTC),
             error=output.error,
         )
 
@@ -325,16 +323,11 @@ def on_invocation_start(
         lambda_context: LambdaContext | None,
     ) -> None:
         aws_request_id = lambda_context.aws_request_id if lambda_context else None
-        invocation_start_time = (
-            datetime.datetime.now(datetime.UTC)
-            if is_first_invocation
-            else execution_start_time
-        )
         self._invocation_status = InvocationStartInfo(
             execution_arn=execution_arn,
             request_id=aws_request_id,
             is_first_invocation=is_first_invocation,
-            start_time=invocation_start_time,
+            execution_start_time=execution_start_time,
         )
         self.execute_plugins(self._invocation_status, sync=True)
 

packages/aws-durable-execution-sdk-python/tests/plugin_test.py

@@ -68,17 +68,16 @@
 INVOCATION_START_INFO = InvocationStartInfo(
     request_id="req-1",
     execution_arn="arn:aws:lambda:us-east-1:123:durable:abc",
-    start_time=START_TS,
+    execution_start_time=START_TS,
     is_first_invocation=True,
 )
 INVOCATION_END_INFO = InvocationEndInfo(
     request_id="req-1",
     execution_arn="arn:test",
-    start_time=START_TS,
+    execution_start_time=START_TS,
     status=InvocationStatus.FAILED,
     error=ERROR,
     is_first_invocation=False,
-    end_time=END_TS,
 )
 
 USER_FUNCTION_START_INFO = UserFunctionStartInfo(
@@ -137,17 +136,16 @@ def test_invocation_start_info(self):
             INVOCATION_START_INFO.execution_arn,
             "arn:aws:lambda:us-east-1:123:durable:abc",
         )
-        self.assertEqual(INVOCATION_START_INFO.start_time, START_TS)
+        self.assertEqual(INVOCATION_START_INFO.execution_start_time, START_TS)
         self.assertTrue(INVOCATION_START_INFO.is_first_invocation)
 
     def test_invocation_end_info(self):
         self.assertEqual(INVOCATION_END_INFO.request_id, "req-1")
         self.assertEqual(INVOCATION_END_INFO.execution_arn, "arn:test")
-        self.assertEqual(INVOCATION_END_INFO.start_time, START_TS)
+        self.assertEqual(INVOCATION_END_INFO.execution_start_time, START_TS)
         self.assertFalse(INVOCATION_END_INFO.is_first_invocation)
         self.assertEqual(INVOCATION_END_INFO.status, InvocationStatus.FAILED)
         self.assertEqual(INVOCATION_END_INFO.error.message, "boom")
-        self.assertEqual(INVOCATION_END_INFO.end_time, END_TS)
 
     def test_user_function_start_info(self):
         self.assertEqual(USER_FUNCTION_START_INFO.operation_id, "op-1")
@@ -408,7 +406,9 @@ def test_first_invocation_fires_invocation_start(self):
             self.assertEqual(
                 LAMBDA_CTX.aws_request_id, self.executor._invocation_status.request_id
             )
-            self.assertEqual(START_TS, self.executor._invocation_status.start_time)
+            self.assertEqual(
+                START_TS, self.executor._invocation_status.execution_start_time
+            )
             self.assertFalse(self.executor._invocation_status.is_first_invocation)
 
         self.assertIsNone(self.executor._invocation_status)