feat: add callback, invoke, wait_for_callback conformance suites - #562
Merged
Merged
Conversation
Adds callback (4-1..4-19), invoke (5-1..5-16), and wait_for_callback (7-1..7-15) suites; template-driven discovery picks them up automatically. Inject script now preserves CloudFormation short-form intrinsic tags, and the workflow uses a stack-safe suite slug plus runner env passthrough.
wangyb-A
force-pushed
the
feature/python-conformance-callback-invoke-wfcb
branch
from
July 21, 2026 21:37
fe09488 to
b719326
Compare
Contributor
|
Let's use stable stack/function names and keep the resources (no-cleanup) when test run completes so that it's easier to troubleshoot issues. Current stack names: 
|
Drop the run id from the conformance stack name so every run reuses conf-py-<suite>, and pass --no-cleanup so the deployed stack is left in the account after the run. Both make failed runs easier to debug; the next run's sam deploy updates the same stack in place.
wangyb-A
marked this pull request as ready for review
July 21, 2026 23:58
Register the CloudFormation short-form tag constructor on SafeLoader directly and parse with yaml.safe_load(stream), instead of yaml.load with a SafeLoader subclass. Unknown tags still become inert CfnTag holders (no arbitrary object construction), and security scanners recognize the safe_load call. Round-trip behavior is unchanged.
Mirror aws-durable-execution-sdk-js#750: keep the scoped CfnLoader (a yaml.SafeLoader subclass) and load via a _safe_load_cfn helper that drives the loader directly, instead of the yaml.load(...) call form flagged by CodeQL or mutating the global SafeLoader. Unknown tags still become inert CfnTag holders; behavior is unchanged.
zhongkechen
reviewed
Jul 22, 2026
added 2 commits
July 22, 2026 19:03
All branches/PRs now deploy to the same per-suite stack names, so the per-branch concurrency group no longer prevents cross-PR collisions. Use a single repo-wide group and queue (cancel-in-progress: false) instead of cancelling, since aborting a mid-deploy run can leave a CloudFormation update in progress on the shared stack. Addresses review feedback from zhongkechen on PR #562.
LAMBDA_ENDPOINT, TEST_ACCOUNT_ID, and TEST_LAMBDA_EXECUTION_ROLE_ARN were copied from the JS conformance workflow, but nothing in the Python path reads them: the pinned runner, the Python SDK, and the package scripts have no references, and boto3 only honors AWS_ENDPOINT_URL[_*] for endpoint overrides. The execution role is injected into the template beforehand; the account check has its own env.
zhongkechen
approved these changes
Jul 22, 2026
wangyb-A
pushed a commit
that referenced
this pull request
Jul 22, 2026
All branches/PRs now deploy to the same per-suite stack names, so the per-branch concurrency group no longer prevents cross-PR collisions. Use a single repo-wide group and queue (cancel-in-progress: false) instead of cancelling, since aborting a mid-deploy run can leave a CloudFormation update in progress on the shared stack. Addresses review feedback from zhongkechen on PR #562.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three conformance suites to
packages/aws-durable-execution-sdk-python-conformance-tests, ported from the language-agnostic requirement mappings:!SubARN wiring andTenancyConfig: PER_TENANTpreserved;lambda:InvokeFunctionadded to the suite role)The template-driven discovery (
scripts/discover_suites.py) picks the new suites up automatically — the CI matrix now generates 5 parallel jobs with no workflow list change.Supporting changes (aligned with the JS repo's conformance CI)
scripts/inject_execution_role.py: CloudFormation short-form intrinsic tags (!Sub,!GetAtt, ...) now survive the load/dump round-trip — required fortemplate_invoke.yaml's target-function ARN references.wait_for_callback→wait-for-callback; underscores are invalid in CloudFormation stack names) andLAMBDA_ENDPOINT/TEST_ACCOUNT_ID/TEST_LAMBDA_EXECUTION_ROLE_ARNenv passthrough on the run step.Testing
discover_suites.py→["callback","invoke","step","wait","wait_for_callback"]build_examples.pyclean rebuild copies all 5 suitessam validate --lintpasses on all 5 templates!Subpreserved)Handlers are copied unmodified from the validated source; no DynamoDB resources introduced.