Commit 33c1cb3
committed
ci: grant actions:read, count jobs safely, cover bundler
Three fixes from the second review on #844.
Add `actions: read`. Declaring a permissions block sets every unnamed scope to
none, and the coverage gate lists the triggering run's jobs, so the Actions API
would have returned 403 and aborted the step on every Dependabot pull request.
It fails closed, but the automation would never have merged anything.
commitlint-comment.yaml declares the same scope for the same reason.
Count job names instead of asking jq for a length. `--paginate` applies `-q` per
page, so a run spanning two pages yields one count per line ("18\n4"), and
`[[ "18\n4" -eq 0 ]]` is an arithmetic syntax error that evaluates false —
skipping the refusal and merging. Verified in bash: the multi-line form errors
with "syntax error in expression" and takes the else branch. Single-page today at
22 jobs, but the failure direction is fail-open, and the headroom is smaller than
it looks.
Add the bundler ecosystem for examples/sinatra/app/src/Gemfile, which the original
sweep missed. Beyond grouping, this is what gives those PRs a conventional commit
prefix: Commit Lint runs on every pull request with no path filter, and #799 shows
what the default message costs — commit "bump
com.fasterxml.jackson.core:jackson-databind", Lint Commit Messages red.1 parent f314573 commit 33c1cb3
2 files changed
Lines changed: 32 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
23 | 28 | | |
24 | 29 | | |
25 | 30 | | |
| |||
98 | 103 | | |
99 | 104 | | |
100 | 105 | | |
101 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
102 | 112 | | |
103 | | - | |
| 113 | + | |
| 114 | + | |
104 | 115 | | |
105 | 116 | | |
106 | 117 | | |
| |||
0 commit comments