Commit 38e46fd
committed
ci: make Verify Examples self-verifying and gate on every check
Three fixes from the third review on #844.
Trigger Verify Examples on its own machinery. The workflow only ran for
examples/**, so a pull request changing example-matrix.json or
select-examples.sh — now the single source of truth for what gets verified —
never ran it. This pull request is the proof: it rewires all three matrices and
its checks are Commit Lint, CodeQL and pr.yaml only, no validate or test-* at
all. The matrix file, the selector directory and this workflow are now triggers,
so it verifies its own changes.
src/, layer/ and Cargo.* are deliberately still not pull request triggers even
though the selector treats them as shared: adding them would run all eighteen
matrix entries on every source pull request. Adapter changes stay verified against
the examples on push to main, and the shared-path rule still applies to a pull
request touching both.
Gate on the whole check rollup, not just this one run. Commit Lint runs on every
pull request with no path filter and does go red on Dependabot PRs (#799), yet the
merge consulted only the Verify Examples run, and any check added later would have
been ignored too. Anything not SUCCESS/SKIPPED/NEUTRAL — including still running,
since a workflow_run job cannot wait — now refuses the merge; Dependabot rebases
these branches often and any later run re-evaluates. Verified against live data:
the query is empty for #842 (all green, CodeQL NEUTRAL) and names the failure on
#844. This workflow's own run is excluded defensively, since an in-progress
self-check would deadlock every merge if workflow_run runs ever joined the rollup.
Add the github-actions ecosystem for the commit prefix, for the same reason
bundler was added: every workflow pins actions, so an advisory would open a PR
with no conventional type and a red Commit Lint. With the limit at 0 it adds no
pull requests. Pre-emptive — there are no open actions alerts today (the 705 open
alerts are npm, pip, go, rubygems, rust and maven).1 parent 33c1cb3 commit 38e46fd
3 files changed
Lines changed: 55 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
106 | 128 | | |
107 | 129 | | |
108 | 130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
9 | 17 | | |
10 | 18 | | |
11 | 19 | | |
12 | 20 | | |
13 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
14 | 27 | | |
15 | 28 | | |
16 | 29 | | |
| |||
0 commit comments