Commit 89a1c58
committed
ci: derive the covered set from the matrix, fix the header sim, assert schedule
Three fixes from review on b13d801.
The uncovered warning still named the kinds, which is the one place a stale list
misleads a person rather than a job: adding a fourth kind would have had it report an
example as "not built or booted" while the new job was building and booting it — a
false claim in the only signal a reviewer has, since the per-example job names vanish
when the matrix is filtered. It now derives the covered set from the file, and the
selector publishes one kind-agnostic `selected` output that examples-verified consumes
instead of binding image/zip/stream a third time.
The simulated commit header now uses the entry's own prefix, and stays deliberately
pessimistic: it assumes the `(deps)` scope and a three-digit update count. That is why
it reads longer than the 137 the comment cites, which was measured without the scope.
The report argued for dropping the scope as too strict; I kept it, because being wrong
in the strict direction costs a shortened group name while being wrong in the lax
direction costs a red Commit Lint on a pull request nobody wrote — which is the whole
reason the assertion exists — and every Dependabot pull request in this repository is
titled `chore(deps): ...`, so the scope is what Dependabot infers here. It still leaves
9 characters of headroom at the longest directory configured today, so the pessimism
costs nothing.
schedule.interval is now asserted. It is required for an updates entry and its absence
is the worst copy-paste failure available: Dependabot rejects the whole file, so all 47
groups stop applying at once. Asserted outside the is_example gate, since an invalid
root cargo or github-actions entry invalidates the file just the same.
Exercised: `selected` on all four selector paths; a fourth matrix kind honoured by both
the warning and `selected`; the gate reporting from the single output and still exiting
1 on a failure; a missing schedule on an example and on github-actions.1 parent b13d801 commit 89a1c58
3 files changed
Lines changed: 46 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
162 | 171 | | |
163 | 172 | | |
164 | 173 | | |
| |||
186 | 195 | | |
187 | 196 | | |
188 | 197 | | |
| 198 | + | |
| 199 | + | |
189 | 200 | | |
190 | 201 | | |
191 | 202 | | |
| |||
206 | 217 | | |
207 | 218 | | |
208 | 219 | | |
209 | | - | |
210 | | - | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
211 | 234 | | |
212 | 235 | | |
213 | 236 | | |
| |||
226 | 249 | | |
227 | 250 | | |
228 | 251 | | |
229 | | - | |
230 | 252 | | |
231 | 253 | | |
232 | 254 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| |||
127 | 128 | | |
128 | 129 | | |
129 | 130 | | |
| 131 | + | |
130 | 132 | | |
131 | 133 | | |
132 | 134 | | |
| |||
139 | 141 | | |
140 | 142 | | |
141 | 143 | | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
142 | 148 | | |
143 | | - | |
| 149 | + | |
144 | 150 | | |
145 | 151 | | |
146 | 152 | | |
| |||
150 | 156 | | |
151 | 157 | | |
152 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
153 | 166 | | |
154 | 167 | | |
155 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
71 | 74 | | |
72 | 75 | | |
73 | 76 | | |
| |||
453 | 456 | | |
454 | 457 | | |
455 | 458 | | |
456 | | - | |
457 | | - | |
458 | | - | |
| 459 | + | |
459 | 460 | | |
460 | 461 | | |
461 | 462 | | |
| |||
473 | 474 | | |
474 | 475 | | |
475 | 476 | | |
476 | | - | |
477 | | - | |
478 | | - | |
479 | | - | |
480 | | - | |
481 | | - | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
482 | 480 | | |
483 | 481 | | |
484 | 482 | | |
| |||
0 commit comments