Repository navigation
Bump Smithy codegen to 1.74.1 - #3988
Merged
Merged
Conversation
pulimsr
force-pushed
the
bump-smithy-1.74
branch
from
November 6, 2026 16:06
0ff9372 to
ed49675
Compare
Madrigal
reviewed
Nov 6, 2026
|
|
||
| val logger = Logging.getLogger("MyLogger") | ||
| val smithyVersion = "1.73.0" | ||
| val smithyVersion = "1.74.1" |
Contributor
There was a problem hiding this comment.
Maybe nit, but if this is on the same file on the same project, and the versions were already the same, should they be the same variable?
Collaborator
Author
There was a problem hiding this comment.
yes makes sense I moved it to gradle.properties and verified it from tools/code-generation/smithy/cpp-codegen with JDK 17
The buildscript block runs before script-body vals exist, so it kept a duplicate copy of the version. Reading it from gradle.properties gives the buildscript, the script body and the smithy-cpp-codegen subproject one shared value.
Madrigal
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Smithy from 1.73.0 to 1.74.1. Smithy is now pinned in two places under
tools/code-generation/smithy/:codegen/settings.gradle.ktscpp-codegen/gradle.properties(smithyVersion), read bycpp-codegen/build.gradle.kts(script body andbuildscript {}) andcpp-codegen/smithy-cpp-codegen/build.gradle.kts. This replaces their hardcoded copies, since thebuildscript {}block runs before script-body vals exist and could not share one.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.