[DO NOT MERGE] Enable default read timeout - #7336
Open
zoewangg wants to merge 4 commits into
Open
Conversation
Mirror the AWS_NEW_RETRIES_2026 gate: add the AWS_ENABLE_DEFAULT_READ_TIMEOUT_2026 system setting, its resolver, the DEFAULT_ENABLE_READ_TIMEOUT_2026 client option, and the codegen customization field that bakes it into mergeInternalDefaults. Nothing consumes the gate yet; the aws-core and CRT client wiring follow separately.
The CRT-based HTTP clients now honor SDK_INTERNAL_FALLBACK_READ_WRITE_TIMEOUT, mapping it onto an HttpMonitoringOptions minimum-throughput monitor. An explicit ConnectionHealthConfiguration takes precedence; a standalone client reads the opt-in environment variable directly.
Codegen bakes each listed service's default read/write timeout tier into its generated serviceHttpConfig from a checked-in exemption artifact; aws-core applies the rollout gate to the baked value.
… to SDK-managed clients (#7334) * fix: scope CRT default timeout to managed clients A directly-supplied CRT client is caller-owned (buildWithDefaults is not called on it) and is often shared across services with different exemption tiers, so applying a flat default could break an exempt service. The client no longer reads the opt-in setting itself; the default now applies only to SDK-managed clients, via the option resolved in aws-core. * docs: clarify CRT default timeout scope in Javadoc Document that the CRT builder's connectionHealthConfiguration applies an automatic default only for SDK-managed clients; a directly-supplied or standalone client gets no default and honors only an explicit configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License