[Default Read/Write Timeout 5/N] Rename rollout gate to AWS_ENABLE_DEFAULT_SOCKET_TIMEOUT_2026 - #7337
Open
zoewangg wants to merge 1 commit into
Conversation
Rename the interim rollout-gate symbols (system setting, env var, property, resolver, client option, codegen customization) from the READ name to the cross-SDK-settled SOCKET name. Behavior-preserving. SDK_INTERNAL_FALLBACK_READ_WRITE_TIMEOUT is intentionally not renamed; it names the read+write mechanism value, not the gate.
Fred1155
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is series item 5/N of the default read/write timeout work. Earlier items introduced an interim, off-by-default rollout gate under the working name
AWS_ENABLE_DEFAULT_READ_TIMEOUT_2026. The cross-SDK teams have since settled onSOCKET(rather thanREAD) as the name for this gate. It is a mechanical, behavior-preserving rename with no functional change.Base branch is the feature branch for this series, not
master.Modifications
Renamed the rollout-gate symbols from the interim
READname to the settledSOCKETname.SdkSystemSetting:AWS_ENABLE_DEFAULT_READ_TIMEOUT_2026->AWS_ENABLE_DEFAULT_SOCKET_TIMEOUT_2026. This also renames the environment variable stringAWS_ENABLE_DEFAULT_SOCKET_TIMEOUT_2026and the system propertyaws.enableDefaultSocketTimeout2026(formerlyaws.enableDefaultReadTimeout2026), which are the customer-facing opt-in names for this interim gate.EnableDefaultReadTimeout2026Resolver->EnableDefaultSocketTimeout2026Resolver(class, file, and its builder method/fielddefaultEnableSocketTimeout2026). The test class/file was renamed to match.SdkClientOption:DEFAULT_ENABLE_READ_TIMEOUT_2026->DEFAULT_ENABLE_SOCKET_TIMEOUT_2026.CustomizationConfig: field + getter/setterdefaultEnableSocketTimeout2026, theBaseClientBuilderClassemission that reads it, and the affected customization/fixture resources.AwsDefaultClientBuilder(aws-core): updated all references to the renamed resolver and client option, plus the associated Javadoc{@code}references.Testing
Built and ran the affected module tests. A repo-wide grep confirms no remaining references to any of the old names
Types of changes
This is a behavior-preserving rename/refactor; neither category above applies.
Checklist
mvn installsucceedsLicense