Repository navigation
feat(metadata store): wire tensorflow-training test suites into test-skip cache - #6623
Merged
samsullivan1 merged 1 commit intoAug 27, 2026
Merged
Conversation
samsullivan1
force-pushed
the
feat/metadata-store-wire-tensorflow-training-tests
branch
from
August 26, 2026 19:19
7d2a830 to
d6e848d
Compare
samsullivan1
force-pushed
the
feat/metadata-store-wire-tensorflow-training-tests
branch
from
August 26, 2026 19:24
d6e848d to
a1b7b0d
Compare
sirutBuasai
approved these changes
Aug 27, 2026
samsullivan1
deleted the
feat/metadata-store-wire-tensorflow-training-tests
branch
August 27, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Wire the three
tensorflow-trainingframework test suites —tensorflow-training/unit,tensorflow-training/single_gpu,tensorflow-training/sagemaker— into the content-addressed test-skip cache: CI skips a suite when a prior PASS exists for the same image content + test code, and records a PASS once the suite genuinely runs and passes. Fail-open throughout — any cache miss, degraded lookup, or infra failure just runs the suite.tensorflow-training.tests-{unit,single-gpu,sagemaker}.yml— each reusable gains optionalimage-content-hash/suite-code-hashinputs and arecord-test-passjob, gated to match each suite's topology:sagemakerruns apreflightjob and gatessagemaker-testat the job level on the image probe, so an absent image leaves itskipped(neversuccess) → the record keys onsagemaker-test.result == 'success'.unitandsingle_gpurun as a single job whose steps self-skip on the image-exists check, so the job can reportsuccesseven when the image is absent. To avoid recording a false PASS, that job exposes animage-existsoutput and the record additionally requiresneeds.<job>.outputs.image-exists == 'true'.tensorflow-training.pipeline.yml— add all three suites to thecheckjob, gateunit-test/single-gpu-test/sagemaker-testson theirskips[...]result (fail-open viaskips || '{}', gated only on build failure — never on the check job), thread the hashes, and preserve the existing gates (single-gpu-testkeepsdevice-type == 'gpu',sagemaker-testskeepscustomer-type == 'sagemaker')..github/config/test-suites.yml— authortensorflow-training/unit→test/tensorflow/unit/**,tensorflow-training/single_gpu→test/tensorflow/single_gpu/**,tensorflow-training/sagemaker→test/tensorflow/integration/training/**.test/tensorflow/is shared with tensorflow-inference, so the globs are scoped to the training-specific subpaths (disjoint fromtest/tensorflow/integration/inference/**). The sagemaker glob captures the suite's test modules plus itsconftest.py,resources/training scripts, and in-dirrequirements.txt. Generic shared harness (roottest/conftest.py,test/test_utils/**, roottest/requirements.txt) is excluded as an accepted cache-hit tradeoff.Test Plan
python -m pytest test/db/test_config_matches_workflows.py test/db/test_hash_suite_code.py— reconciliation (invoked suites exist in config; skip accessors are configured and checked) + suite-code hashing resolves to real files.unit/single_gpujobs vs. the job-level-gatedsagemaker) and code_paths disjointness from tensorflow-inference.Test Result
*.ymlparse as YAML; everytensorflow-training/*accessor is present in the check-job suites list and the gated jobs'if:.Live CI validation — record → hit (clean HIT)
Validated via test PR #6644 (no-op Dockerfile edit → CPU build; single-gpu/sagemaker disabled). Run
32877989279:sanity+telemetry+tensorflow-training/unitrecorded PASS rows → sanity, telemetry, unit.checkhit → all three skipped with no re-record: sanity, telemetry, unit.Toggle if you are merging into master Branch
By default, docker image builds and tests are disabled. Two ways to run builds and tests:
How to use the helper utility for updating dlc_developer_config.toml
Assuming your remote is called
origin(you can find out more withgit remote -v)...python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp originpython src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp originpython src/prepare_dlc_dev_environment.py -rcp originNOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:
sagemaker_remote_tests = truesagemaker_efa_tests = truesagemaker_rc_tests = truesagemaker_local_tests = trueHow to use PR description
Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:# /buildspec <buildspec_path># /buildspec pytorch/training/buildspec.yml# /tests <test_list># /tests sanity security ec2sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.Toggle if you are merging into main Branch
PR Checklist
pre-commit run --all-fileslocally before creating this PR. (Read DEVELOPMENT.md for details).