Skip to content

Commit 044768f

Browse files
committed
fix: resolve intelligent defaults bug in ImageRetriever by replacing ineffective locals() assignment with args dict
1 parent 74983e5 commit 044768f

1 file changed

Lines changed: 36 additions & 5 deletions

File tree

‎sagemaker-core/src/sagemaker/core/image_retriever/image_retriever.py‎

Lines changed: 36 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
config_for_framework,
2626
)
2727
from sagemaker.core.workflow.utilities import override_pipeline_parameter_var
28-
from sagemaker.core.config.config_schema import IMAGE_RETRIEVER, MODULES, SAGEMAKER, _simple_path
28+
from sagemaker.core.config.config_schema import IMAGE_RETRIEVER, MODULES, PYTHON_SDK, SAGEMAKER, _simple_path
2929
from sagemaker.core.config.config_manager import SageMakerConfig
3030

3131
ECR_URI_TEMPLATE = "{registry}.dkr.{hostname}/{repository}"
@@ -114,11 +114,25 @@ def retrieve_hugging_face_uri(
114114
if name in CONFIGURABLE_ATTRIBUTES and not val:
115115
default_value = ImageRetriever._config.resolve_value_from_config(
116116
config_path=_simple_path(
117-
SAGEMAKER, MODULES, IMAGE_RETRIEVER, to_camel_case(name)
117+
SAGEMAKER, PYTHON_SDK, MODULES, IMAGE_RETRIEVER, to_camel_case(name)
118118
)
119119
)
120120
if default_value is not None:
121-
locals()[name] = default_value
121+
args[name] = default_value
122+
123+
# Apply resolved defaults back to local variables
124+
version = args.get("version", version)
125+
py_version = args.get("py_version", py_version)
126+
instance_type = args.get("instance_type", instance_type)
127+
accelerator_type = args.get("accelerator_type", accelerator_type)
128+
image_scope = args.get("image_scope", image_scope)
129+
container_version = args.get("container_version", container_version)
130+
distributed = args.get("distributed", distributed)
131+
base_framework_version = args.get("base_framework_version", base_framework_version)
132+
training_compiler_config = args.get("training_compiler_config", training_compiler_config)
133+
sdk_version = args.get("sdk_version", sdk_version)
134+
inference_tool = args.get("inference_tool", inference_tool)
135+
serverless_inference_config = args.get("serverless_inference_config", serverless_inference_config)
122136

123137
if training_compiler_config:
124138
final_image_scope = image_scope
@@ -503,11 +517,28 @@ def retrieve(
503517
if name in CONFIGURABLE_ATTRIBUTES and not val:
504518
default_value = ImageRetriever._config.resolve_value_from_config(
505519
config_path=_simple_path(
506-
SAGEMAKER, MODULES, IMAGE_RETRIEVER, to_camel_case(name)
520+
SAGEMAKER, PYTHON_SDK, MODULES, IMAGE_RETRIEVER, to_camel_case(name)
507521
)
508522
)
509523
if default_value is not None:
510-
locals()[name] = default_value
524+
args[name] = default_value
525+
526+
# Apply resolved defaults back to local variables
527+
version = args.get("version", version)
528+
py_version = args.get("py_version", py_version)
529+
instance_type = args.get("instance_type", instance_type)
530+
accelerator_type = args.get("accelerator_type", accelerator_type)
531+
image_scope = args.get("image_scope", image_scope)
532+
container_version = args.get("container_version", container_version)
533+
distributed = args.get("distributed", distributed)
534+
smp = args.get("smp", smp)
535+
base_framework_version = args.get("base_framework_version", base_framework_version)
536+
training_compiler_config = args.get("training_compiler_config", training_compiler_config)
537+
model_id = args.get("model_id", model_id)
538+
model_version = args.get("model_version", model_version)
539+
sdk_version = args.get("sdk_version", sdk_version)
540+
inference_tool = args.get("inference_tool", inference_tool)
541+
serverless_inference_config = args.get("serverless_inference_config", serverless_inference_config)
511542

512543
for name, val in args.items():
513544
if is_pipeline_variable(val):

0 commit comments

Comments
 (0)