Skip to content

Commit 0e5df55

Browse files
author
hrehard
committed
fix(examples): correct recipe-override precedence asserts in SFT notebook
The precedence-verification cell asserted training_config["learning_rate"] and ["num_epochs"], but the resolved Nova recipe exposes neither key, so the notebook fails with KeyError: 'learning_rate'. - The learning_rate override is applied under training_config.optim_config.lr (value 5e-6), not a top-level training_config.learning_rate. - num_epochs is not a Nova recipe key — Nova SFT is step-based (max_steps), so the recipe resolver drops the num_epochs override. Override and assert max_steps (the step-based equivalent of epochs) instead of num_epochs, and assert optim_config.lr. Precedence table updated to match. Verified the overrides take effect (optim_config.lr=5e-6, max_steps=20).
1 parent 6659b11 commit 0e5df55

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎v3-examples/model-customization-examples/recipe_override_sft_trainer_example.ipynb‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@
154154
" overrides={\n",
155155
" \"training_config\": {\n",
156156
" \"learning_rate\": 5e-6, # Override: lower learning rate\n",
157-
" \"num_epochs\": 5 # Override: more epochs\n",
157+
" \"max_steps\": 20 # Override: more steps\n",
158158
" }\n",
159159
" }\n",
160160
")\n",
@@ -373,7 +373,7 @@
373373
"| Parameter | Recipe File | Override | Resolved (Used) | Source |\n",
374374
"|-----------|------------|----------|-----------------|--------|\n",
375375
"| `learning_rate` | 1e-5 | 5e-6 | **5e-6** | Override wins |\n",
376-
"| `num_epochs` | 3 | 5 | **5** | Override wins |\n",
376+
"| `max_steps` | 10 (default) | 20 | **20** | Override wins |\n",
377377
"| `batch_size` | 8 | (not set) | **8** | Recipe file |\n",
378378
"| `sequence_length` | 2048 | (not set) | **2048** | Recipe file |"
379379
],
@@ -398,8 +398,8 @@
398398
" print(f\" {key}: {value}\")\n",
399399
"\n",
400400
"# Overrides win over recipe file values\n",
401-
"assert training_config[\"learning_rate\"] == 5e-6, \"Override should win\"\n",
402-
"assert training_config[\"num_epochs\"] == 5, \"Override should win\"\n",
401+
"assert training_config[\"optim_config\"][\"lr\"] == 5e-6, \"Override should win\"\n",
402+
"assert training_config[\"max_steps\"] == 20, \"Override should win\"\n",
403403
"\n",
404404
"print(\"\\nAll precedence checks passed!\")"
405405
],

0 commit comments

Comments
 (0)