Repository navigation
Commit 0e5df55
hrehard
fix(examples): correct recipe-override precedence asserts in SFT notebook
The precedence-verification cell asserted training_config["learning_rate"] and
["num_epochs"], but the resolved Nova recipe exposes neither key, so the notebook
fails with KeyError: 'learning_rate'.
- The learning_rate override is applied under training_config.optim_config.lr
(value 5e-6), not a top-level training_config.learning_rate.
- num_epochs is not a Nova recipe key — Nova SFT is step-based (max_steps), so
the recipe resolver drops the num_epochs override.
Override and assert max_steps (the step-based equivalent of epochs) instead of
num_epochs, and assert optim_config.lr. Precedence table updated to match.
Verified the overrides take effect (optim_config.lr=5e-6, max_steps=20).1 parent 6659b11 commit 0e5df55
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
| 157 | + | |
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
| |||
373 | 373 | | |
374 | 374 | | |
375 | 375 | | |
376 | | - | |
| 376 | + | |
377 | 377 | | |
378 | 378 | | |
379 | 379 | | |
| |||
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
401 | | - | |
402 | | - | |
| 401 | + | |
| 402 | + | |
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
| |||
0 commit comments