Repository navigation
Commit 376f2a7
change: add image_uri_config for TensorFlow inference 2.20 and training 2.21 (#6230)
* change: add image_uri_config for TensorFlow inference 2.20 and training 2.21
Register the newly released SageMaker TensorFlow DLCs in tensorflow.json:
* inference 2.20.0 -> tensorflow-inference:2.20.0-{cpu,gpu}-py312, plus the
2.20 minor alias
* training 2.21.0 -> tensorflow-training:2.21.0-{cpu,gpu}-py312, plus the
2.21 minor alias
Both are Python 3.12 / AL2023 builds, GPU variants on CUDA 12.9.1. The registry
maps match the 38 regions already used by 2.19.0.
Unlike earlier inference entries, 2.20.0 sets py_versions to ["py312"] because
the published tags carry the Python suffix; the bare 2.20.0-cpu form used by
2.19 and earlier is not published for this release.
Add tests/unit/image_uris/test_tensorflow.py, the first image-URI tests for the
TensorFlow training and inference scopes, following the config-driven pattern
used by test_vllm.py and test_sglang.py.
* change: strengthen TensorFlow image_uri_config tests
Address review feedback on the new TensorFlow image-URI tests:
* Assert that the version covered by this file is the newest one registered in
tensorflow.json, so adding a newer version fails with a message naming it.
The previous membership check let a new version go silently uncovered.
* Assert the new version's registry map against the previous release's rather
than against its own entry. Reading the expected account out of the config
under test meant a wrong account or a dropped region could never fail.
* Cover the Python-version behaviour of the new inference entry: py312 is the
only option for 2.20, and 2.19 still resolves to a tag with no py suffix.
* Drop the incidental trailing newline added to tensorflow.json.
* change: clarify TensorFlow image_uri_config test comments
Correct the FULL_URI_REGIONS rationale: the registry map contains no ISO
partition regions, and cn-north-1 is the only listed region with a
non-default ECR domain.
Narrow the REGISTRY_REFERENCE_VERSION comment to what the assertion
actually guarantees. It catches a one-sided mistake in a new version's
registry map, not a change applied to both versions, and it does not
verify that the images are published in those regions. Also note that
bumping it to the newly added version makes the account assertions
tautological.
Comments only; no assertions changed.
---------
Co-authored-by: Bhanu Teja Goshikonda <bhanugk@amazon.com>1 parent 18cb28c commit 376f2a7
2 files changed
Lines changed: 270 additions & 2 deletions
File tree
- sagemaker-core
- src/sagemaker/core/image_uri_config
- tests/unit/image_uris
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
337 | | - | |
| 337 | + | |
| 338 | + | |
338 | 339 | | |
339 | 340 | | |
340 | 341 | | |
| |||
2515 | 2516 | | |
2516 | 2517 | | |
2517 | 2518 | | |
| 2519 | + | |
| 2520 | + | |
| 2521 | + | |
| 2522 | + | |
| 2523 | + | |
| 2524 | + | |
| 2525 | + | |
| 2526 | + | |
| 2527 | + | |
| 2528 | + | |
| 2529 | + | |
| 2530 | + | |
| 2531 | + | |
| 2532 | + | |
| 2533 | + | |
| 2534 | + | |
| 2535 | + | |
| 2536 | + | |
| 2537 | + | |
| 2538 | + | |
| 2539 | + | |
| 2540 | + | |
| 2541 | + | |
| 2542 | + | |
| 2543 | + | |
| 2544 | + | |
| 2545 | + | |
| 2546 | + | |
| 2547 | + | |
| 2548 | + | |
| 2549 | + | |
| 2550 | + | |
| 2551 | + | |
| 2552 | + | |
| 2553 | + | |
| 2554 | + | |
| 2555 | + | |
| 2556 | + | |
| 2557 | + | |
| 2558 | + | |
| 2559 | + | |
| 2560 | + | |
| 2561 | + | |
| 2562 | + | |
| 2563 | + | |
| 2564 | + | |
2518 | 2565 | | |
2519 | 2566 | | |
2520 | 2567 | | |
| |||
2820 | 2867 | | |
2821 | 2868 | | |
2822 | 2869 | | |
2823 | | - | |
| 2870 | + | |
| 2871 | + | |
2824 | 2872 | | |
2825 | 2873 | | |
2826 | 2874 | | |
| |||
5080 | 5128 | | |
5081 | 5129 | | |
5082 | 5130 | | |
| 5131 | + | |
| 5132 | + | |
| 5133 | + | |
| 5134 | + | |
| 5135 | + | |
| 5136 | + | |
| 5137 | + | |
| 5138 | + | |
| 5139 | + | |
| 5140 | + | |
| 5141 | + | |
| 5142 | + | |
| 5143 | + | |
| 5144 | + | |
| 5145 | + | |
| 5146 | + | |
| 5147 | + | |
| 5148 | + | |
| 5149 | + | |
| 5150 | + | |
| 5151 | + | |
| 5152 | + | |
| 5153 | + | |
| 5154 | + | |
| 5155 | + | |
| 5156 | + | |
| 5157 | + | |
| 5158 | + | |
| 5159 | + | |
| 5160 | + | |
| 5161 | + | |
| 5162 | + | |
| 5163 | + | |
| 5164 | + | |
| 5165 | + | |
| 5166 | + | |
| 5167 | + | |
| 5168 | + | |
| 5169 | + | |
| 5170 | + | |
| 5171 | + | |
| 5172 | + | |
| 5173 | + | |
| 5174 | + | |
| 5175 | + | |
| 5176 | + | |
5083 | 5177 | | |
5084 | 5178 | | |
5085 | 5179 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
0 commit comments