Skip to content

Commit 4b3c156

Browse files
authored
fix(serve): dedicated INFERENCE_RECOMMENDER telemetry feature + type workload param (#6028)
Address review nits on the AI inference recommender: - Add Feature.INFERENCE_RECOMMENDER telemetry enum + FEATURE_TO_CODE mapping; tag generate_deployment_recommendations, start_benchmark, and show_result with it instead of MODEL_CUSTOMIZATION. - Type generate_deployment_recommendations(workload=...) as Optional[Union[Workload, str]] to match the other params.
1 parent 89ac414 commit 4b3c156

5 files changed

Lines changed: 7 additions & 5 deletions

File tree

‎sagemaker-core/src/sagemaker/core/telemetry/constants.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ class Feature(Enum):
3232
PROCESSING = 18
3333
MODEL_CUSTOMIZATION_NOVA = 19
3434
MODEL_CUSTOMIZATION_OSS = 20
35+
INFERENCE_RECOMMENDER = 21
3536

3637
def __str__(self): # pylint: disable=E0307
3738
"""Return the feature name."""

‎sagemaker-core/src/sagemaker/core/telemetry/telemetry_logging.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
str(Feature.PROCESSING): 18,
7777
str(Feature.MODEL_CUSTOMIZATION_NOVA): 19,
7878
str(Feature.MODEL_CUSTOMIZATION_OSS): 20,
79+
str(Feature.INFERENCE_RECOMMENDER): 21,
7980
}
8081

8182
STATUS_TO_CODE = {

‎sagemaker-serve/src/sagemaker/serve/ai_inference_recommender/_model_builder_methods.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _map_service_error(error: Exception) -> Exception:
8181

8282

8383
@_telemetry_emitter(
84-
feature=Feature.MODEL_CUSTOMIZATION, func_name="ai_inference_recommender.start_benchmark"
84+
feature=Feature.INFERENCE_RECOMMENDER, func_name="ai_inference_recommender.start_benchmark"
8585
)
8686
def start_benchmark(
8787
endpoint: Union[Endpoint, str],

‎sagemaker-serve/src/sagemaker/serve/ai_inference_recommender/jobs.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class BenchmarkJob(AIBenchmarkJob):
3434
"""
3535

3636
@_telemetry_emitter(
37-
feature=Feature.MODEL_CUSTOMIZATION, func_name="BenchmarkJob.show_result"
37+
feature=Feature.INFERENCE_RECOMMENDER, func_name="BenchmarkJob.show_result"
3838
)
3939
def show_result(self):
4040
"""Download the benchmark output from S3 and return a parsed result.
@@ -58,7 +58,7 @@ class RecommendationJob(AIRecommendationJob):
5858
"""
5959

6060
@_telemetry_emitter(
61-
feature=Feature.MODEL_CUSTOMIZATION, func_name="RecommendationJob.show_result"
61+
feature=Feature.INFERENCE_RECOMMENDER, func_name="RecommendationJob.show_result"
6262
)
6363
def show_result(self) -> "_RecommendationsView":
6464
"""Return the ranked recommendations produced by the job.

‎sagemaker-serve/src/sagemaker/serve/model_builder.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4428,12 +4428,12 @@ def _model_builder_optimize_wrapper(
44284428
return self.built_model
44294429

44304430
@_telemetry_emitter(
4431-
feature=Feature.MODEL_CUSTOMIZATION,
4431+
feature=Feature.INFERENCE_RECOMMENDER,
44324432
func_name="ModelBuilder.generate_deployment_recommendations",
44334433
)
44344434
def generate_deployment_recommendations(
44354435
self,
4436-
workload=None,
4436+
workload: Optional[Union["Workload", str]] = None,
44374437
performance_target: Optional[Union[str, "PerformanceTarget"]] = None,
44384438
*,
44394439
output_path: Optional[str] = None,

0 commit comments

Comments
 (0)