Skip to content

Commit 51646f5

Browse files
mujtaba1747Syed Jafri
andauthored
fix: rever preset reward function deletion from hyperparams dict (#6181)
Co-authored-by: Syed Jafri <syedjfr@amazon.com>
1 parent c1d48ab commit 51646f5

2 files changed

Lines changed: 17 additions & 3 deletions

File tree

‎sagemaker-train/src/sagemaker/train/rlvr_trainer.py‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,9 +240,6 @@ def _process_hyperparameters(self):
240240
if hasattr(self.hyperparameters, 'reward_lambda_arn'):
241241
delattr(self.hyperparameters, 'reward_lambda_arn')
242242
self.hyperparameters._specs.pop('reward_lambda_arn', None)
243-
if hasattr(self.hyperparameters, 'preset_reward_function'):
244-
delattr(self.hyperparameters, 'preset_reward_function')
245-
self.hyperparameters._specs.pop('preset_reward_function', None)
246243
if hasattr(self.hyperparameters, 'data_path'):
247244
delattr(self.hyperparameters, 'data_path')
248245
self.hyperparameters._specs.pop('data_path', None)
@@ -410,7 +407,22 @@ def train(self, training_dataset: Optional[Union[str, DataSet]] = None,
410407
411408
Returns:
412409
TrainingJob: The SageMaker training job object, or None if dry_run=True.
410+
411+
Raises:
412+
ValueError: If neither a custom reward function nor a preset reward
413+
function hyperparameter is configured.
413414
"""
415+
# A reward signal is required: either a custom reward function (Lambda ARN,
416+
# evaluator ARN, or Evaluator object) or the preset_reward_function hyperparameter.
417+
preset_reward_function = getattr(self.hyperparameters, "preset_reward_function", None)
418+
if not self.custom_reward_function and not preset_reward_function:
419+
raise ValueError(
420+
"RLVR training requires a reward signal. Provide either "
421+
"'custom_reward_function' (a Lambda ARN, evaluator ARN, or Evaluator object) "
422+
"when initializing RLVRTrainer, or set the 'preset_reward_function' "
423+
"hyperparameter (e.g. trainer.hyperparameters.preset_reward_function = 'prime_code')."
424+
)
425+
414426
# Dispatch based on compute type
415427
if isinstance(self.compute, HyperPodCompute):
416428
return self._train_hyperpod(

‎sagemaker-train/tests/integ/train/test_rlvr_trainer_integration.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ def test_rlvr_trainer_lora_complete_workflow(sagemaker_session):
9292
accept_eula=True,
9393
base_job_name=f"rlvr-lora-integ-{unique_id}",
9494
)
95+
96+
rlvr_trainer.hyperparameters.preset_reward_function = "prime_code"
9597

9698
# Create training job
9799
training_job = rlvr_trainer.train(wait=False)

0 commit comments

Comments
 (0)