@@ -893,9 +893,10 @@ def test_falls_back_to_default_region_when_none_resolved(self, mock_boto_session
893893class TestEmitFailureTelemetry (unittest .TestCase ):
894894 """Tests for the failure-only _emit_failure_telemetry helper."""
895895
896+ @patch ("sagemaker.core.telemetry.telemetry_logging.resolve_value_from_config" , return_value = False )
896897 @patch ("sagemaker.core.telemetry.telemetry_logging._get_default_sagemaker_session" )
897898 @patch ("sagemaker.core.telemetry.telemetry_logging._send_telemetry_request" )
898- def test_emits_failure_event (self , mock_send , mock_default_session ):
899+ def test_emits_failure_event (self , mock_send , mock_default_session , mock_optout ):
899900 mock_default_session .return_value = Mock ()
900901 exc = ValueError ("bad value" )
901902
@@ -908,18 +909,33 @@ def test_emits_failure_event(self, mock_send, mock_default_session):
908909 assert args [4 ] == "ValueError" # failure_type
909910 assert "MyClass.method" in args [5 ] # extra_info carries func_name
910911
912+ @patch ("sagemaker.core.telemetry.telemetry_logging.resolve_value_from_config" , return_value = True )
911913 @patch ("sagemaker.core.telemetry.telemetry_logging._get_default_sagemaker_session" )
912914 @patch ("sagemaker.core.telemetry.telemetry_logging._send_telemetry_request" )
913- def test_no_session_does_not_emit (self , mock_send , mock_default_session ):
915+ def test_opt_out_suppresses_emit (self , mock_send , mock_default_session , mock_optout ):
916+ # A user who has opted out of telemetry must not have these events emitted.
917+ mock_default_session .return_value = Mock ()
918+
919+ _emit_failure_telemetry (Feature .MODEL_CUSTOMIZATION , "MyClass.method" , ValueError ("x" ))
920+
921+ mock_send .assert_not_called ()
922+
923+ @patch ("sagemaker.core.telemetry.telemetry_logging.resolve_value_from_config" , return_value = False )
924+ @patch ("sagemaker.core.telemetry.telemetry_logging._get_default_sagemaker_session" )
925+ @patch ("sagemaker.core.telemetry.telemetry_logging._send_telemetry_request" )
926+ def test_no_session_does_not_emit (self , mock_send , mock_default_session , mock_optout ):
914927 mock_default_session .return_value = None
915928
916929 _emit_failure_telemetry (Feature .MODEL_CUSTOMIZATION , "MyClass.method" , ValueError ("x" ))
917930
918931 mock_send .assert_not_called ()
919932
933+ @patch ("sagemaker.core.telemetry.telemetry_logging.resolve_value_from_config" , return_value = False )
920934 @patch ("sagemaker.core.telemetry.telemetry_logging._get_default_sagemaker_session" )
921935 @patch ("sagemaker.core.telemetry.telemetry_logging._send_telemetry_request" )
922- def test_uses_provided_session_without_default_lookup (self , mock_send , mock_default_session ):
936+ def test_uses_provided_session_without_default_lookup (
937+ self , mock_send , mock_default_session , mock_optout
938+ ):
923939 _emit_failure_telemetry (
924940 Feature .MODEL_CUSTOMIZATION , "MyClass.method" , ValueError ("x" ),
925941 sagemaker_session = Mock (),
@@ -928,9 +944,10 @@ def test_uses_provided_session_without_default_lookup(self, mock_send, mock_defa
928944 mock_default_session .assert_not_called ()
929945 mock_send .assert_called_once ()
930946
947+ @patch ("sagemaker.core.telemetry.telemetry_logging.resolve_value_from_config" , return_value = False )
931948 @patch ("sagemaker.core.telemetry.telemetry_logging._get_default_sagemaker_session" )
932949 @patch ("sagemaker.core.telemetry.telemetry_logging._send_telemetry_request" )
933- def test_backend_error_is_swallowed (self , mock_send , mock_default_session ):
950+ def test_backend_error_is_swallowed (self , mock_send , mock_default_session , mock_optout ):
934951 # Telemetry is best-effort: an error while emitting must never propagate.
935952 mock_default_session .return_value = Mock ()
936953 mock_send .side_effect = RuntimeError ("telemetry backend down" )
0 commit comments