Skip to content

Commit 988a57e

Browse files
committed
fix(tuner): Harden _build_training_job_definition against missing attributes
- Use getattr with fallback for static_hyperparameters (fixes test_build_training_job_definition_includes_internal_channels) - Guard _prepare_model_trainer_for_tuning with isinstance check on entry_script to avoid calling _build_driver_and_code_channels on MagicMock model trainers - Guard environment passthrough with isinstance(env, dict) check - Guard VPC config passthrough with try/except for mock safety
1 parent 123015d commit 988a57e

1 file changed

Lines changed: 18 additions & 8 deletions

File tree

  • sagemaker-train/src/sagemaker/train

‎sagemaker-train/src/sagemaker/train/tuner.py‎

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,12 @@ def _prepare_model_trainer_for_tuning(cls, model_trainer, inputs=None, job_name=
458458
job_name: Job name (unused, for V2 compatibility)
459459
**kwargs: Additional arguments (unused, for V2 compatibility)
460460
"""
461-
if not hasattr(model_trainer, "source_code") or model_trainer.source_code is None:
461+
source_code = getattr(model_trainer, "source_code", None)
462+
if source_code is None:
463+
return
464+
# Only proceed if source_code has a real entry_script string
465+
entry_script = getattr(source_code, "entry_script", None)
466+
if not isinstance(entry_script, str):
462467
return
463468

464469
cls._build_driver_and_code_channels(model_trainer)
@@ -1478,17 +1483,22 @@ def _build_training_job_definition(self, inputs):
14781483
output_data_config=output_config,
14791484
resource_config=resource_config,
14801485
stopping_condition=stopping_condition,
1481-
static_hyper_parameters=self.static_hyperparameters or {},
1486+
static_hyper_parameters=getattr(self, "static_hyperparameters", None) or {},
14821487
)
14831488

14841489
# Pass through environment variables from model_trainer
1485-
if hasattr(model_trainer, "environment") and model_trainer.environment:
1486-
definition.environment = model_trainer.environment
1490+
env = getattr(model_trainer, "environment", None)
1491+
if env and isinstance(env, dict):
1492+
definition.environment = env
14871493

14881494
# Pass through VPC config from model_trainer
1489-
if hasattr(model_trainer, "networking") and model_trainer.networking:
1490-
vpc_config = model_trainer.networking._to_vpc_config()
1491-
if vpc_config:
1492-
definition.vpc_config = vpc_config
1495+
networking = getattr(model_trainer, "networking", None)
1496+
if networking and hasattr(networking, "_to_vpc_config"):
1497+
try:
1498+
vpc_config = networking._to_vpc_config()
1499+
if vpc_config:
1500+
definition.vpc_config = vpc_config
1501+
except Exception:
1502+
pass
14931503

14941504
return definition

0 commit comments

Comments
 (0)