Repository navigation
Commit 9ae355d
fix(resources): fall back to ARN in ModelPackage.refresh for versioned packages (#6378)
ModelPackage.get_all() over a model package group fails with
ParamValidationError: Missing required parameter "ModelPackageName". The
ResourceIterator calls refresh() on each constructed ModelPackage, and
refresh() built its describe input from self.model_package_name only. For
versioned packages ListModelPackages returns only ModelPackageArn, so
model_package_name stays Unassigned, serializes to None, is dropped from the
request, and the describe call fails (#5606).
DescribeModelPackage accepts either the name or the ARN for the
ModelPackageName parameter, so refresh() now falls back to
model_package_arn when model_package_name is Unassigned.
resources.py is generated, so the fix is in the generator: add a scoped
REFRESH_IDENTIFIER_FALLBACKS map and emit the fallback in
_generate_operation_input_necessary_args, wired in only for refresh. The
blast radius is limited to ModelPackage.refresh -- update already excludes
identifiers and every other resource is unchanged. resources.py is the
regenerated output of this change (ModelPackage.refresh hunk only).
Add runtime tests covering the ARN fallback and the name path.
Relates-to #5606
Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com>1 parent febee60 commit 9ae355d
3 files changed
Lines changed: 74 additions & 7 deletions
File tree
- sagemaker-core
- src/sagemaker/core
- tools
- tests/unit/generated
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22984 | 22984 | | |
22985 | 22985 | | |
22986 | 22986 | | |
22987 | | - | |
| 22987 | + | |
| 22988 | + | |
| 22989 | + | |
| 22990 | + | |
| 22991 | + | |
22988 | 22992 | | |
22989 | 22993 | | |
22990 | 22994 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
101 | 109 | | |
102 | 110 | | |
103 | 111 | | |
| |||
761 | 769 | | |
762 | 770 | | |
763 | 771 | | |
764 | | - | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
765 | 776 | | |
766 | 777 | | |
767 | 778 | | |
| |||
770 | 781 | | |
771 | 782 | | |
772 | 783 | | |
773 | | - | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
774 | 788 | | |
775 | 789 | | |
776 | 790 | | |
777 | 791 | | |
778 | 792 | | |
779 | 793 | | |
780 | 794 | | |
| 795 | + | |
781 | 796 | | |
782 | 797 | | |
783 | | - | |
784 | | - | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
785 | 809 | | |
786 | | - | |
| 810 | + | |
787 | 811 | | |
788 | 812 | | |
789 | 813 | | |
| |||
1300 | 1324 | | |
1301 | 1325 | | |
1302 | 1326 | | |
1303 | | - | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
1304 | 1330 | | |
1305 | 1331 | | |
1306 | 1332 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
935 | 935 | | |
936 | 936 | | |
937 | 937 | | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
0 commit comments