Repository navigation
Commit 9ff3e5f
authored
fix(serve): remove IC data-source collapse hack from recommendation deploy (#6101)
* fix(serve): remove IC data-source collapse hack from recommendation deploy
Inference Components now support AdditionalModelDataSources natively (kernel
tuning / speculative decoding channels), so _deploy_recommendation no longer
needs to collapse an optimized recommendation's base_model + draft channels
into a single primary ModelDataSource. Deploy the recommendation's
ModelPackage directly and let the hosting stack resolve the channels.
Removes the base_model-promotion / OPTION_SPECULATIVE_DRAFT_MODEL rewiring
block and its now-unused shape imports (AdditionalModelDataSource,
ModelDataSource, S3ModelDataSource, SPECULATIVE_DRAFT_MODEL). Updates the
speculative-decoding unit tests to assert the ModelPackage pass-through.
* test(serve): integ test deploying an SD/KT model as an Inference Component
Adds an end-to-end integration test that builds a model carrying
speculative-decoding / kernel-tuning AdditionalModelDataSources (base +
draft channels) and deploys it as an Inference Component via
ModelBuilder.deploy(inference_config=ResourceRequirements(...)). Asserts the
Inference Component reaches InService and that the deployed model still
carries the additional sources (guards against a silent client-side
collapse). Marked slow_test + gpu_intensive.
* test(serve): fix SD/KT IC integ test build path and trim docstring
The test built the IC model via ModelBuilder(model_path=<s3_uri>), which
raises 'Cannot detect required model or inference spec' — a raw S3 path is
not a buildable model spec. Build via ModelBuilder.from_jumpstart_config so
the container/framework resolve, then attach additional_model_data_sources
(carried onto the model through _prepare_container_def_base) before deploying
as an Inference Component. Also switch the IC instance to g4dn.xlarge (a GPU
is needed for the vLLM/LMI container, not for the 0.6B size) and trim the
module docstring.
* test(serve): poll IC to terminal state before asserting + harden teardown
deploy(wait=True) waits for the endpoint, but the Inference Component is
created with wait=False, so the IC can still be Creating when deploy()
returns. Add _wait_for_ic_terminal to poll the IC to InService/Failed before
the status assertion, and wait it out of Creating before teardown (an IC in
Creating cannot be deleted, which would strand its GPU endpoint).1 parent 136706e commit 9ff3e5f
3 files changed
Lines changed: 286 additions & 121 deletions
File tree
- sagemaker-serve
- src/sagemaker/serve
- tests
- integ
- unit/test_ai_inference_recommender
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
5158 | 5158 | | |
5159 | 5159 | | |
5160 | 5160 | | |
5161 | | - | |
5162 | 5161 | | |
5163 | | - | |
5164 | 5162 | | |
5165 | 5163 | | |
5166 | | - | |
5167 | 5164 | | |
5168 | 5165 | | |
5169 | 5166 | | |
| |||
5275 | 5272 | | |
5276 | 5273 | | |
5277 | 5274 | | |
5278 | | - | |
5279 | | - | |
5280 | | - | |
5281 | | - | |
5282 | | - | |
5283 | | - | |
5284 | | - | |
5285 | | - | |
5286 | | - | |
5287 | | - | |
5288 | | - | |
5289 | | - | |
5290 | | - | |
5291 | | - | |
5292 | | - | |
5293 | | - | |
5294 | | - | |
5295 | | - | |
5296 | | - | |
5297 | | - | |
5298 | | - | |
5299 | | - | |
5300 | | - | |
5301 | | - | |
5302 | | - | |
5303 | | - | |
5304 | | - | |
5305 | | - | |
5306 | | - | |
5307 | | - | |
5308 | | - | |
5309 | | - | |
5310 | | - | |
5311 | | - | |
5312 | | - | |
5313 | | - | |
5314 | | - | |
5315 | | - | |
5316 | | - | |
5317 | | - | |
5318 | | - | |
5319 | | - | |
5320 | | - | |
5321 | | - | |
5322 | | - | |
5323 | | - | |
5324 | | - | |
5325 | | - | |
5326 | | - | |
5327 | | - | |
5328 | | - | |
5329 | | - | |
5330 | | - | |
5331 | | - | |
5332 | | - | |
5333 | | - | |
5334 | | - | |
5335 | | - | |
5336 | | - | |
| 5275 | + | |
| 5276 | + | |
| 5277 | + | |
| 5278 | + | |
| 5279 | + | |
| 5280 | + | |
| 5281 | + | |
| 5282 | + | |
| 5283 | + | |
5337 | 5284 | | |
5338 | 5285 | | |
5339 | 5286 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
0 commit comments