Repository navigation
Commit a1e7add
Rishabh Devnani
fix(tests): Use the shared session fixtures in the new integ tests
Both new integ tests defined local sagemaker_session and pipeline_session
fixtures returning a bare Session() / PipelineSession(), shadowing the
shared ones in tests/integ/conftest.py. CI runs the integ suite with
AWS_DEFAULT_REGION unset, so a bare session has no region and both tests
error at setup with "Must setup local AWS configuration with a region
supported by SageMaker".
The local role fixture went too, since the shared conftest provides one. The
shared fixtures build on a boto3.Session carrying an explicit region, which
is exactly what was missing.
Found on the v2 equivalent of these tests, where CI reported it; the same
shadowing was present here and would have failed the same way once these
tests ran.
Testing: both integ tests re-run against the service using the shared
fixtures -- lineage in 15.62s with AWS_DEFAULT_REGION unset, and the chained
EndpointConfig -> Endpoint -> InferenceComponent pipeline in 413.44s -- with
no resources left behind. 327 workflow unit tests still pass.
---
X-AI-Prompt: did you read the comment on the pr?
X-AI-Tool: kiro-cli1 parent 2665140 commit a1e7add
2 files changed
Lines changed: 8 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | 34 | | |
37 | 35 | | |
38 | 36 | | |
| |||
42 | 40 | | |
43 | 41 | | |
44 | 42 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
58 | 47 | | |
59 | 48 | | |
60 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
43 | | - | |
44 | 42 | | |
45 | 43 | | |
46 | 44 | | |
| |||
49 | 47 | | |
50 | 48 | | |
51 | 49 | | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
65 | 54 | | |
66 | 55 | | |
67 | 56 | | |
| |||
0 commit comments