@@ -355,6 +355,107 @@ def test_transform_job_describe(self, mock_session_class):
355355 assert description ["ModelName" ] == "test-model"
356356
357357
358+ class TestPerformBatchInferencePathTraversal :
359+ """Test _perform_batch_inference blocks path traversal attacks."""
360+
361+ @patch ("sagemaker.core.local.local_session.LocalSession" )
362+ def test_path_traversal_in_file_list (self , mock_session_class ):
363+ """Test that file paths resolving outside working_dir are blocked."""
364+ mock_session = Mock ()
365+ mock_client = Mock ()
366+ mock_client .describe_model .return_value = {
367+ "PrimaryContainer" : {
368+ "Image" : "test-image:latest" ,
369+ "ModelDataUrl" : "s3://bucket/model.tar.gz" ,
370+ "Environment" : {},
371+ }
372+ }
373+ mock_session .sagemaker_client = mock_client
374+
375+ job = _LocalTransformJob ("test-job" , "test-model" , mock_session )
376+
377+ with tempfile .TemporaryDirectory () as working_dir :
378+ with tempfile .TemporaryDirectory () as dataset_dir :
379+ # Mock _get_working_directory to return our temp dir
380+ job ._get_working_directory = Mock (return_value = working_dir )
381+
382+ # Create a mock data source with a traversal path
383+ mock_data_source = Mock ()
384+ mock_data_source .get_root_dir .return_value = dataset_dir
385+ # Simulate a file that would resolve outside working_dir via relpath
386+ traversal_file = os .path .join (dataset_dir , ".." , ".." , ".." , "etc" , "passwd" )
387+ mock_data_source .get_file_list .return_value = [traversal_file ]
388+
389+ mock_batch_provider = Mock ()
390+
391+ job ._prepare_data_transformation = Mock (
392+ return_value = (mock_data_source , mock_batch_provider )
393+ )
394+
395+ input_data = {"ContentType" : "text/csv" }
396+ output_data = {"S3OutputPath" : "s3://bucket/output" , "Accept" : "text/csv" }
397+
398+ with pytest .raises (ValueError , match = "Path traversal detected" ):
399+ job ._perform_batch_inference (
400+ input_data , output_data , BatchStrategy = "MultiRecord" , MaxPayloadInMB = "6"
401+ )
402+
403+ @patch ("sagemaker.core.local.local_session.LocalSession" )
404+ def test_safe_file_paths_are_allowed (self , mock_session_class ):
405+ """Test that normal file paths within dataset_dir are allowed."""
406+ mock_session = Mock ()
407+ mock_client = Mock ()
408+ mock_client .describe_model .return_value = {
409+ "PrimaryContainer" : {
410+ "Image" : "test-image:latest" ,
411+ "ModelDataUrl" : "s3://bucket/model.tar.gz" ,
412+ "Environment" : {},
413+ }
414+ }
415+ mock_session .sagemaker_client = mock_client
416+ mock_session .sagemaker_runtime_client = Mock ()
417+ mock_session .sagemaker_runtime_client .invoke_endpoint .return_value = {
418+ "Body" : Mock (read = Mock (return_value = b"result" ), close = Mock ())
419+ }
420+
421+ job = _LocalTransformJob ("test-job" , "test-model" , mock_session )
422+
423+ with tempfile .TemporaryDirectory () as working_dir :
424+ with tempfile .TemporaryDirectory () as dataset_dir :
425+ # Create a real file in the dataset dir
426+ test_file = os .path .join (dataset_dir , "input.csv" )
427+ with open (test_file , "w" ) as f :
428+ f .write ("test data" )
429+
430+ job ._get_working_directory = Mock (return_value = working_dir )
431+
432+ mock_data_source = Mock ()
433+ mock_data_source .get_root_dir .return_value = dataset_dir
434+ mock_data_source .get_file_list .return_value = [test_file ]
435+
436+ mock_batch_provider = Mock ()
437+ mock_batch_provider .pad .return_value = [b"test data" ]
438+
439+ job ._prepare_data_transformation = Mock (
440+ return_value = (mock_data_source , mock_batch_provider )
441+ )
442+
443+ job .container = Mock ()
444+
445+ input_data = {"ContentType" : "text/csv" }
446+ output_data = {"S3OutputPath" : "s3://bucket/output" , "Accept" : "text/csv" }
447+
448+ # Patch move_to_destination to avoid S3 interaction
449+ with patch ("sagemaker.core.local.entities.move_to_destination" ):
450+ job ._perform_batch_inference (
451+ input_data , output_data , BatchStrategy = "MultiRecord" , MaxPayloadInMB = "6"
452+ )
453+
454+ # Verify the output file was created inside working_dir
455+ expected_output = os .path .join (working_dir , "input.csv.out" )
456+ assert os .path .exists (expected_output )
457+
458+
358459class TestLocalModel :
359460 """Test cases for _LocalModel"""
360461
0 commit comments