Repository navigation
Commit d1dfbbb
committed
fix(processing): Fix V3 shape regressions in processors
PySparkProcessor still built ProcessingInput/ProcessingOutput with the V2
source/destination keyword signature, so spark_event_logs_s3_uri and the
configuration channel failed on V3. Build them with the V3 shapes
(ProcessingS3Input/ProcessingS3Output) instead. Validate that
submit_py_files, submit_jars and submit_files are lists and raise a clear
ValueError otherwise. FrameworkProcessor.run(requirements=...) now threads
the file name into the generated runproc.sh instead of hardcoding
requirements.txt. Processor.run defaults kms_key to the configured
output_kms_key so uploaded code is encrypted with the same key as job
outputs.
The requirements file is also honored on the custom entry_point (S3
source_dir) path, and a relative path such as reqs/cpu.txt is kept as-is
because the source bundle preserves the source_dir layout.
Integration tests (real jobs, submit-then-stop where the fix is in the
request path) cover the code-upload KMS fallback, the FrameworkProcessor
requirements file, and a V3 PySparkProcessor job ported from V2 that
asserts the event-log output and the conf/py-files input shape; V3 had
no Spark integ coverage before.
Fixes #3809
Fixes #6253
Fixes #6252
Fixes #5805
Fixes #4874
---
X-AI-Prompt: Fix S-effort PySDK V3 bugs, processing-spark theme
X-AI-Tool: Kiro1 parent 7ac2708 commit d1dfbbb
11 files changed
Lines changed: 1806 additions & 19 deletions
File tree
- sagemaker-core
- src/sagemaker/core
- spark
- tests
- data/spark
- code/python/hello_py_spark
- files
- integ
- processing
- spark
- unit
- spark
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
335 | | - | |
| 335 | + | |
| 336 | + | |
336 | 337 | | |
337 | 338 | | |
338 | 339 | | |
| |||
343 | 344 | | |
344 | 345 | | |
345 | 346 | | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
346 | 353 | | |
347 | 354 | | |
348 | 355 | | |
| |||
903 | 910 | | |
904 | 911 | | |
905 | 912 | | |
906 | | - | |
| 913 | + | |
| 914 | + | |
907 | 915 | | |
908 | 916 | | |
909 | 917 | | |
| |||
914 | 922 | | |
915 | 923 | | |
916 | 924 | | |
917 | | - | |
| 925 | + | |
918 | 926 | | |
919 | 927 | | |
920 | 928 | | |
| |||
1481 | 1489 | | |
1482 | 1490 | | |
1483 | 1491 | | |
| 1492 | + | |
1484 | 1493 | | |
1485 | 1494 | | |
1486 | 1495 | | |
| |||
1526 | 1535 | | |
1527 | 1536 | | |
1528 | 1537 | | |
| 1538 | + | |
1529 | 1539 | | |
1530 | 1540 | | |
1531 | 1541 | | |
1532 | 1542 | | |
1533 | 1543 | | |
1534 | 1544 | | |
1535 | | - | |
| 1545 | + | |
1536 | 1546 | | |
1537 | 1547 | | |
1538 | 1548 | | |
| |||
1551 | 1561 | | |
1552 | 1562 | | |
1553 | 1563 | | |
1554 | | - | |
| 1564 | + | |
1555 | 1565 | | |
1556 | 1566 | | |
1557 | 1567 | | |
| |||
1560 | 1570 | | |
1561 | 1571 | | |
1562 | 1572 | | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
1563 | 1587 | | |
1564 | 1588 | | |
1565 | 1589 | | |
1566 | 1590 | | |
1567 | 1591 | | |
1568 | 1592 | | |
| 1593 | + | |
1569 | 1594 | | |
1570 | 1595 | | |
1571 | 1596 | | |
1572 | 1597 | | |
1573 | | - | |
| 1598 | + | |
1574 | 1599 | | |
1575 | 1600 | | |
1576 | 1601 | | |
| 1602 | + | |
1577 | 1603 | | |
1578 | 1604 | | |
1579 | 1605 | | |
| |||
1597 | 1623 | | |
1598 | 1624 | | |
1599 | 1625 | | |
1600 | | - | |
| 1626 | + | |
1601 | 1627 | | |
1602 | 1628 | | |
1603 | 1629 | | |
1604 | | - | |
| 1630 | + | |
1605 | 1631 | | |
1606 | 1632 | | |
1607 | 1633 | | |
1608 | 1634 | | |
1609 | 1635 | | |
| 1636 | + | |
1610 | 1637 | | |
1611 | 1638 | | |
1612 | 1639 | | |
| |||
1617 | 1644 | | |
1618 | 1645 | | |
1619 | 1646 | | |
| 1647 | + | |
1620 | 1648 | | |
1621 | 1649 | | |
1622 | 1650 | | |
| |||
1630 | 1658 | | |
1631 | 1659 | | |
1632 | 1660 | | |
| 1661 | + | |
| 1662 | + | |
1633 | 1663 | | |
1634 | 1664 | | |
1635 | 1665 | | |
| |||
1639 | 1669 | | |
1640 | 1670 | | |
1641 | 1671 | | |
| 1672 | + | |
1642 | 1673 | | |
1643 | 1674 | | |
1644 | 1675 | | |
| |||
1655 | 1686 | | |
1656 | 1687 | | |
1657 | 1688 | | |
1658 | | - | |
| 1689 | + | |
1659 | 1690 | | |
1660 | | - | |
| 1691 | + | |
1661 | 1692 | | |
1662 | 1693 | | |
1663 | 1694 | | |
| |||
1667 | 1698 | | |
1668 | 1699 | | |
1669 | 1700 | | |
| 1701 | + | |
1670 | 1702 | | |
1671 | 1703 | | |
1672 | 1704 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
330 | 331 | | |
331 | 332 | | |
332 | 333 | | |
333 | | - | |
334 | | - | |
335 | | - | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
336 | 340 | | |
337 | 341 | | |
338 | 342 | | |
| |||
444 | 448 | | |
445 | 449 | | |
446 | 450 | | |
447 | | - | |
448 | | - | |
449 | 451 | | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
450 | 458 | | |
451 | 459 | | |
452 | 460 | | |
| |||
473 | 481 | | |
474 | 482 | | |
475 | 483 | | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
476 | 489 | | |
477 | 490 | | |
478 | 491 | | |
| |||
544 | 557 | | |
545 | 558 | | |
546 | 559 | | |
| 560 | + | |
547 | 561 | | |
548 | | - | |
549 | | - | |
550 | 562 | | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
551 | 569 | | |
552 | 570 | | |
553 | | - | |
| 571 | + | |
554 | 572 | | |
555 | | - | |
| 573 | + | |
556 | 574 | | |
557 | 575 | | |
558 | 576 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
0 commit comments