Repository navigation
Commit edc851c
committed
fix(instance-preferences): stop pydantic serializer warnings for unset preference fields
Compute's validator converts Unassigned() to None on its own fields but
not on the nested InstancePreference objects, so every submit with a
preference list emitted one PydanticSerializationUnexpectedValue warning
per element (for the unset training_plan_arns list) when
_to_resource_config() called model_dump(). The request payload was
already correct; the noise was the only effect.
Both Compute classes now normalise each preference the same way. The
serialized ResourceConfig is unchanged. A test asserts
_to_resource_config() completes with warnings turned into errors.1 parent f883b2f commit edc851c
3 files changed
Lines changed: 34 additions & 0 deletions
File tree
- sagemaker-core
- src/sagemaker/core
- modules
- training
- tests/unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
169 | 173 | | |
170 | 174 | | |
171 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
197 | 201 | | |
198 | 202 | | |
199 | 203 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
| 6 | + | |
| 7 | + | |
4 | 8 | | |
5 | 9 | | |
6 | 10 | | |
| |||
337 | 341 | | |
338 | 342 | | |
339 | 343 | | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
0 commit comments