Repository navigation
Commit ee8bf12
authored
fix: remove codecov after_n_builds so single-submodule PRs report coverage (#6056)
`after_n_builds: 4` made Codecov wait for four coverage uploads before
finalizing a report. But this repo's CI runs unit tests only for the
submodules a PR changes (detect-changes), so a PR touching 1-3 submodules
produces fewer than four uploads. Codecov then waits forever and never
posts a report or status.
Observed on PR #6055 (changed only sagemaker-mlops): the mlops unit-test
job uploaded coverage successfully, but Codecov reported state=error,
sessions=0 and posted no codecov/project or codecov/patch status, because
it was still waiting for three more uploads that never come.
Drop the fixed count and rely on `wait_for_ci: true`, which finalizes the
report once CI completes using whatever uploaded — correct for this repo's
dynamic per-submodule CI.1 parent 368a1a9 commit ee8bf12
1 file changed
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
17 | 22 | | |
18 | | - | |
19 | 23 | | |
20 | 24 | | |
21 | 25 | | |
| |||
0 commit comments