fix: do not apply user ignore_patterns to the SDK-owned sm_drivers channel (#6328)

ModelTrainer forwarded the user's source_code.ignore_patterns to the
sm_drivers input channel, which packages SDK-owned driver content (e.g.
container_drivers/scripts/environment.py). User patterns such as "scripts"
or "environment" then stripped files the container bootstrap requires,
failing execution with
"sm_drivers/scripts/environment.py: No such file or directory". Drop the
ignore_patterns argument on the sm_drivers channel so it uploads unfiltered;
user patterns still apply to the user's own source_dir (SM_CODE) channel.
Also corrects the create_input_data_channel docstring, which wrongly claimed
a default filter list (the default is None -> no filter).

Adds a regression test asserting SM_CODE keeps the user patterns and
SM_DRIVERS receives none.

Fixes #5493

Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com>

Author: mohamedzeidan2021

src/sagemaker/modules/train/model_trainer.py

@@ -717,12 +717,15 @@ def _create_training_job_args(
             self._write_source_code_json(tmp_dir=self._temp_code_dir, source_code=self.source_code)
             self._write_distributed_json(tmp_dir=self._temp_code_dir, distributed=self.distributed)
 
-            # Create an input channel for drivers packaged by the sdk
+            # Create an input channel for drivers packaged by the sdk.
+            # Do NOT apply the user's source_code.ignore_patterns here: this directory is
+            # SDK-owned driver content (e.g. scripts/environment.py), and user patterns such as
+            # "scripts" or "environment" would strip files the container bootstrap requires,
+            # causing "sm_drivers/scripts/environment.py: No such file or directory" (issue #5493).
             sm_drivers_channel = self.create_input_data_channel(
                 channel_name=SM_DRIVERS,
                 data_source=self._temp_code_dir.name,
                 key_prefix=input_data_key_prefix,
-                ignore_patterns=self.source_code.ignore_patterns,
             )
             final_input_data_config.append(sm_drivers_channel)
 
@@ -881,8 +884,7 @@ def create_input_data_channel(
                 ``s3://<default_bucket_path>/<key_prefix>/<channel_name>/``
             ignore_patterns: (Optional[List[str]]) :
                 The ignore patterns to ignore specific files/folders when uploading to S3.
-                If not specified, default to: ['.env', '.git', '__pycache__', '.DS_Store',
-                '.cache', '.ipynb_checkpoints'].
+                If not specified, no files are filtered and the data source is uploaded as-is.
         """
         channel = None
         if isinstance(data_source, str):

tests/unit/sagemaker/modules/train/test_model_trainer.py

@@ -68,6 +68,7 @@
     DataSource,
     MetricDefinition,
 )
+from sagemaker.modules.constants import SM_CODE, SM_DRIVERS
 from sagemaker.modules.distributed import Torchrun, SMP, MPI
 from sagemaker.modules.train.sm_recipes.utils import _load_recipes_cfg
 from sagemaker.modules.templates import EXEUCTE_DISTRIBUTED_DRIVER
@@ -254,6 +255,47 @@ def test_train_with_default_params(mock_training_job, model_trainer):
     training_job_instance.wait.assert_called_once_with(logs=True)
 
 
+@patch("sagemaker.modules.train.model_trainer.TrainingJob")
+@patch("sagemaker.modules.train.model_trainer.ModelTrainer.create_input_data_channel")
+def test_sm_drivers_channel_ignores_user_ignore_patterns(
+    mock_create_input_data_channel, mock_training_job, modules_session
+):
+    """Regression for #5493.
+
+    The user's ``ignore_patterns`` apply only to their own source_dir channel. They must NOT be
+    forwarded to the SDK-owned ``sm_drivers`` driver channel -- patterns like ``"scripts"`` or
+    ``"environment"`` would strip the driver's own ``scripts/environment.py`` and break the
+    container bootstrap with "sm_drivers/scripts/environment.py: No such file or directory".
+    """
+    user_patterns = ["scripts", "environment", "data"]
+    trainer = ModelTrainer(
+        training_image=DEFAULT_IMAGE,
+        role=DEFAULT_ROLE,
+        compute=DEFAULT_COMPUTE_CONFIG,
+        stopping_condition=DEFAULT_STOPPING_CONDITION,
+        output_data_config=DEFAULT_OUTPUT_DATA_CONFIG,
+        source_code=SourceCode(
+            source_dir=DEFAULT_SOURCE_DIR,
+            entry_script="custom_script.py",
+            ignore_patterns=user_patterns,
+        ),
+        sagemaker_session=modules_session,
+    )
+
+    trainer.train()
+
+    calls_by_channel = {
+        call.kwargs.get("channel_name"): call.kwargs
+        for call in mock_create_input_data_channel.call_args_list
+    }
+    assert SM_CODE in calls_by_channel, "source_dir channel was not created"
+    assert SM_DRIVERS in calls_by_channel, "sm_drivers channel was not created"
+    # User patterns still apply to the user's own source_dir channel.
+    assert calls_by_channel[SM_CODE].get("ignore_patterns") == user_patterns
+    # ...but must NOT be applied to the SDK-owned driver channel.
+    assert calls_by_channel[SM_DRIVERS].get("ignore_patterns") is None
+
+
 @pytest.mark.parametrize(
     "default_config",
     [